Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: third_party/WebKit/ManualTests/printing-resize-starts-transition.html

Issue 2089373002: Resize is being triggered too early in Print code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Landing with a Manual Test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/printing/renderer/print_web_view_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/ManualTests/printing-resize-starts-transition.html
diff --git a/third_party/WebKit/ManualTests/printing-resize-starts-transition.html b/third_party/WebKit/ManualTests/printing-resize-starts-transition.html
new file mode 100644
index 0000000000000000000000000000000000000000..fc4f2e2dd09f58683358bc841deef716a3e64c07
--- /dev/null
+++ b/third_party/WebKit/ManualTests/printing-resize-starts-transition.html
@@ -0,0 +1,30 @@
+<!-- This should be a Browser test, unable to create one to land the fix needed here: https://codereview.chromium.org/2089373002 hence landing as a ManualTest for now. See progress here: crbug.com/634565
+ -->
+<!DOCTYPE html>
+
+<style>
+#target {
+ padding-top: 1000px;
+}
+
+@media screen and (max-width: 600px) {
+ #target {
+ padding: 0;
+ transition: 10s all;
+ }
+}
+
+@media print {
+ #target {
+ padding: 0 !important;
+ }
+}
+</style>
+
+<div id="target">
+To run this test:</br>
+1. Open this file in Chrome</br>
+2. Note that there is a large padding (1000px) at the top of the text</br>
+3. Open in Print Preview</br>
+4. The test passes if there is no padding at the top.</br>
+</div>
« no previous file with comments | « components/printing/renderer/print_web_view_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698