Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 2089373002: Resize is being triggered too early in Print code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Landing with a Manual Test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/ManualTests/printing-resize-starts-transition.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/printing/renderer/print_web_view_helper.cc
diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc
index 0169f36a885a033351469cc1142f17e003f018fa..b194534f33d56758a965d85e6504b5e59b777c77 100644
--- a/components/printing/renderer/print_web_view_helper.cc
+++ b/components/printing/renderer/print_web_view_helper.cc
@@ -712,11 +712,11 @@ void PrepareFrameAndViewForPrint::ResizeForPrinting() {
}
void PrepareFrameAndViewForPrint::StartPrinting() {
- ResizeForPrinting();
blink::WebView* web_view = frame_.view();
web_view->settings()->setShouldPrintBackgrounds(should_print_backgrounds_);
expected_pages_count_ =
frame()->printBegin(web_print_params_, node_to_print_);
+ ResizeForPrinting();
is_printing_started_ = true;
}
« no previous file with comments | « no previous file | third_party/WebKit/ManualTests/printing-resize-starts-transition.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698