Issue 2089353003: Un-deprecate modal dialogs during microtasks

Issue 2089353003: Un-deprecate modal dialogs during microtasks (Closed)

Created:
4 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
4 years, 6 months ago

Reviewers:
Rick Byers

CC:
chromium-reviews, blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Un-deprecate modal dialogs during microtasks We still plan to disallow SyncXHR, but bump the removal to M54 BUG=605517 R=rbyers@chromium.org Committed: https://crrev.com/6052c6b8df5a08fd9ea88243a7ad3c46182c7dfc Cr-Commit-Position: refs/heads/master@{#401841}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -51 lines)			Patch
D	third_party/WebKit/LayoutTests/fast/dom/modal-dialogs-during-microtasks.html	View		1 chunk	+0 lines, -14 lines	0 comments	Download
D	third_party/WebKit/LayoutTests/fast/dom/modal-dialogs-during-microtasks-expected.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/fast/workers/worker-xhr-microtasks-expected.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/frame/Deprecation.cpp	View		1 chunk	+1 line, -13 lines	0 comments	Download
M	third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp	View		4 chunks	+4 lines, -20 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089353003/20001

4 years, 6 months ago (2016-06-24 08:19:14 UTC) #4

commit-bot: I haz the power

4 years, 6 months ago (2016-06-24 09:29:22 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/6052c6b8df5a08fd9ea88243a7ad3c46182c7dfc
Cr-Commit-Position: refs/heads/master@{#401841}