Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2089353003: Un-deprecate modal dialogs during microtasks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/Deprecation.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
index b8654e64feaa78cac66fb22cce269c567ac7bc34..acb9c564fe8604d60c744ab3aabfae70f529d958 100644
--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
@@ -753,11 +753,7 @@ void LocalDOMWindow::print(ScriptState* scriptState)
}
if (scriptState && v8::MicrotasksScope::IsRunningMicrotasks(scriptState->isolate())) {
- Deprecation::countDeprecation(frame()->document(), UseCounter::During_Microtask_Print);
- if (RuntimeEnabledFeatures::disableBlockingMethodsDuringMicrotasksEnabled()) {
- frameConsole()->addMessage(ConsoleMessage::create(SecurityMessageSource, ErrorMessageLevel, "Ignored call to 'print()' during microtask execution."));
- return;
- }
+ UseCounter::count(frame()->document(), UseCounter::During_Microtask_Print);
}
if (frame()->isLoading()) {
@@ -789,11 +785,7 @@ void LocalDOMWindow::alert(ScriptState* scriptState, const String& message)
}
if (v8::MicrotasksScope::IsRunningMicrotasks(scriptState->isolate())) {
- Deprecation::countDeprecation(frame()->document(), UseCounter::During_Microtask_Alert);
- if (RuntimeEnabledFeatures::disableBlockingMethodsDuringMicrotasksEnabled()) {
- frameConsole()->addMessage(ConsoleMessage::create(SecurityMessageSource, ErrorMessageLevel, "Ignored call to 'alert()' during microtask execution."));
- return;
- }
+ UseCounter::count(frame()->document(), UseCounter::During_Microtask_Alert);
}
frame()->document()->updateStyleAndLayoutTree();
@@ -819,11 +811,7 @@ bool LocalDOMWindow::confirm(ScriptState* scriptState, const String& message)
}
if (v8::MicrotasksScope::IsRunningMicrotasks(scriptState->isolate())) {
- Deprecation::countDeprecation(frame()->document(), UseCounter::During_Microtask_Confirm);
- if (RuntimeEnabledFeatures::disableBlockingMethodsDuringMicrotasksEnabled()) {
- frameConsole()->addMessage(ConsoleMessage::create(SecurityMessageSource, ErrorMessageLevel, "Ignored call to 'confirm()' during microtask execution."));
- return false;
- }
+ UseCounter::count(frame()->document(), UseCounter::During_Microtask_Confirm);
}
frame()->document()->updateStyleAndLayoutTree();
@@ -849,11 +837,7 @@ String LocalDOMWindow::prompt(ScriptState* scriptState, const String& message, c
}
if (v8::MicrotasksScope::IsRunningMicrotasks(scriptState->isolate())) {
- Deprecation::countDeprecation(frame()->document(), UseCounter::During_Microtask_Prompt);
- if (RuntimeEnabledFeatures::disableBlockingMethodsDuringMicrotasksEnabled()) {
- frameConsole()->addMessage(ConsoleMessage::create(SecurityMessageSource, ErrorMessageLevel, "Ignored call to 'prompt()' during microtask execution."));
- return String();
- }
+ UseCounter::count(frame()->document(), UseCounter::During_Microtask_Prompt);
}
frame()->document()->updateStyleAndLayoutTree();
« no previous file with comments | « third_party/WebKit/Source/core/frame/Deprecation.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698