Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2945)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2089323002: Refactored FullscreenController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment and nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 4ab8af89a5846f6f22131b898c78520a55fe9f89..a68e0cffc1b69f83b37091569872d968861be381 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1854,10 +1854,16 @@ willAnimateFromState:(BookmarkBar::State)oldState
[self enterAppKitFullscreen];
}
-- (void)updateFullscreenWithToolbar:(BOOL)withToolbar {
+- (void)updateUIForTabFullscreen:(BOOL)isTabFullscreen {
+ DCHECK([self isInAnyFullscreenMode]);
+ if (isTabFullscreen) {
+ [self adjustUIForSlidingFullscreenStyle:fullscreen_mac::OMNIBOX_TABS_NONE];
+ return;
+ }
+
[self adjustUIForSlidingFullscreenStyle:
- withToolbar ? fullscreen_mac::OMNIBOX_TABS_PRESENT
- : fullscreen_mac::OMNIBOX_TABS_HIDDEN];
+ shouldShowFullscreenToolbar_ ? fullscreen_mac::OMNIBOX_TABS_PRESENT
+ : fullscreen_mac::OMNIBOX_TABS_HIDDEN];
}
- (void)updateFullscreenExitBubble {
@@ -1881,8 +1887,9 @@ willAnimateFromState:(BookmarkBar::State)oldState
[presentationModeController_ setToolbarFraction:0.0];
shouldShowFullscreenToolbar_ = visible;
- if ([self isInAppKitFullscreen])
- [self updateFullscreenWithToolbar:shouldShowFullscreenToolbar_];
+ [self adjustUIForSlidingFullscreenStyle:
+ shouldShowFullscreenToolbar_ ? fullscreen_mac::OMNIBOX_TABS_PRESENT
+ : fullscreen_mac::OMNIBOX_TABS_HIDDEN];
}
- (BOOL)isInAnyFullscreenMode {

Powered by Google App Engine
This is Rietveld 408576698