Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2089323002: Refactored FullscreenController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment and nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/browser_window_controller.h" 5 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <numeric> 8 #include <numeric>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 1836 matching lines...) Expand 10 before | Expand all | Expand 10 after
1847 @implementation BrowserWindowController(Fullscreen) 1847 @implementation BrowserWindowController(Fullscreen)
1848 1848
1849 - (void)handleLionToggleFullscreen { 1849 - (void)handleLionToggleFullscreen {
1850 chrome::ExecuteCommand(browser_.get(), IDC_FULLSCREEN); 1850 chrome::ExecuteCommand(browser_.get(), IDC_FULLSCREEN);
1851 } 1851 }
1852 1852
1853 - (void)enterBrowserFullscreen { 1853 - (void)enterBrowserFullscreen {
1854 [self enterAppKitFullscreen]; 1854 [self enterAppKitFullscreen];
1855 } 1855 }
1856 1856
1857 - (void)updateFullscreenWithToolbar:(BOOL)withToolbar { 1857 - (void)updateUIForTabFullscreen:(BOOL)isTabFullscreen {
1858 DCHECK([self isInAnyFullscreenMode]);
1859 if (isTabFullscreen) {
1860 [self adjustUIForSlidingFullscreenStyle:fullscreen_mac::OMNIBOX_TABS_NONE];
1861 return;
1862 }
1863
1858 [self adjustUIForSlidingFullscreenStyle: 1864 [self adjustUIForSlidingFullscreenStyle:
1859 withToolbar ? fullscreen_mac::OMNIBOX_TABS_PRESENT 1865 shouldShowFullscreenToolbar_ ? fullscreen_mac::OMNIBOX_TABS_PRESENT
1860 : fullscreen_mac::OMNIBOX_TABS_HIDDEN]; 1866 : fullscreen_mac::OMNIBOX_TABS_HIDDEN];
1861 } 1867 }
1862 1868
1863 - (void)updateFullscreenExitBubble { 1869 - (void)updateFullscreenExitBubble {
1864 [self layoutSubviews]; 1870 [self layoutSubviews];
1865 [self showFullscreenExitBubbleIfNecessary]; 1871 [self showFullscreenExitBubbleIfNecessary];
1866 } 1872 }
1867 1873
1868 - (BOOL)exitExtensionFullscreenIfPossible { 1874 - (BOOL)exitExtensionFullscreenIfPossible {
1869 if (browser_->exclusive_access_manager() 1875 if (browser_->exclusive_access_manager()
1870 ->fullscreen_controller() 1876 ->fullscreen_controller()
1871 ->IsExtensionFullscreenOrPending()) { 1877 ->IsExtensionFullscreenOrPending()) {
1872 browser_->extension_window_controller()->SetFullscreenMode(NO, GURL()); 1878 browser_->extension_window_controller()->SetFullscreenMode(NO, GURL());
1873 return YES; 1879 return YES;
1874 } 1880 }
1875 return NO; 1881 return NO;
1876 } 1882 }
1877 1883
1878 - (void)setFullscreenToolbarVisible:(BOOL)visible { 1884 - (void)setFullscreenToolbarVisible:(BOOL)visible {
1879 if (shouldShowFullscreenToolbar_ == visible) 1885 if (shouldShowFullscreenToolbar_ == visible)
1880 return; 1886 return;
1881 1887
1882 [presentationModeController_ setToolbarFraction:0.0]; 1888 [presentationModeController_ setToolbarFraction:0.0];
1883 shouldShowFullscreenToolbar_ = visible; 1889 shouldShowFullscreenToolbar_ = visible;
1884 if ([self isInAppKitFullscreen]) 1890 [self adjustUIForSlidingFullscreenStyle:
1885 [self updateFullscreenWithToolbar:shouldShowFullscreenToolbar_]; 1891 shouldShowFullscreenToolbar_ ? fullscreen_mac::OMNIBOX_TABS_PRESENT
1892 : fullscreen_mac::OMNIBOX_TABS_HIDDEN];
1886 } 1893 }
1887 1894
1888 - (BOOL)isInAnyFullscreenMode { 1895 - (BOOL)isInAnyFullscreenMode {
1889 return [self isInImmersiveFullscreen] || [self isInAppKitFullscreen]; 1896 return [self isInImmersiveFullscreen] || [self isInAppKitFullscreen];
1890 } 1897 }
1891 1898
1892 - (BOOL)isInImmersiveFullscreen { 1899 - (BOOL)isInImmersiveFullscreen {
1893 return fullscreenWindow_.get() != nil || enteringImmersiveFullscreen_; 1900 return fullscreenWindow_.get() != nil || enteringImmersiveFullscreen_;
1894 } 1901 }
1895 1902
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
2024 2031
2025 - (NSRect)savedRegularWindowFrame { 2032 - (NSRect)savedRegularWindowFrame {
2026 return savedRegularWindowFrame_; 2033 return savedRegularWindowFrame_;
2027 } 2034 }
2028 2035
2029 - (BOOL)isFullscreenTransitionInProgress { 2036 - (BOOL)isFullscreenTransitionInProgress {
2030 return enteringAppKitFullscreen_ || exitingAppKitFullscreen_; 2037 return enteringAppKitFullscreen_ || exitingAppKitFullscreen_;
2031 } 2038 }
2032 2039
2033 @end // @implementation BrowserWindowController(WindowType) 2040 @end // @implementation BrowserWindowController(WindowType)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698