bluetooth: Avoid use of lambda to work around clang bug.

bluetooth: Avoid use of lambda to work around clang bug.

Clang has a bug [1] that is exposed by the use of a lambda in this unit
test. Until that is fixed, work around it by turning the lambda into a static
function. Should help unblock the next clang roll.

[1] https://llvm.org/bugs/show_bug.cgi?id=28299

BUG=623209
R=ortuno@chromium.org,thakis@chromium.org

Committed: https://crrev.com/292962a4de3a928fbc25539ab557169b86e89e88
Cr-Commit-Position: refs/heads/master@{#402043}

[ortuno, 2016-06-25 00:19:36]

https://codereview.chromium.org/2089313006/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/2089313006/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:403: static
void test_callback(
Since this is no longer a lambda you can remove the cast to function pointer in
base::Bind on line 421, right?

[pcc1, 2016-06-25 00:26:39]

https://codereview.chromium.org/2089313006/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/2089313006/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:403: static
void test_callback(
On 2016/06/25 00:19:36, ortuno wrote:
> Since this is no longer a lambda you can remove the cast to function pointer
in
> base::Bind on line 421, right?

Done.

[ortuno, 2016-06-25 00:29:31]

Thanks! lgtm

[pcc1, 2016-06-25 00:30:13]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2016-06-25 00:30:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-25 01:50:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-25 01:52:15]

Description was changed from

==========
bluetooth: Avoid use of lambda to work around clang bug.

Clang has a bug [1] that is exposed by the use of a lambda in this unit
test. Until that is fixed, work around it by turning the lambda into a static
function. Should help unblock the next clang roll.

[1] https://llvm.org/bugs/show_bug.cgi?id=28299

BUG=623209
R=ortuno@chromium.org,thakis@chromium.org
==========

to

==========
bluetooth: Avoid use of lambda to work around clang bug.

Clang has a bug [1] that is exposed by the use of a lambda in this unit
test. Until that is fixed, work around it by turning the lambda into a static
function. Should help unblock the next clang roll.

[1] https://llvm.org/bugs/show_bug.cgi?id=28299

BUG=623209
R=ortuno@chromium.org,thakis@chromium.org

Committed: https://crrev.com/292962a4de3a928fbc25539ab557169b86e89e88
Cr-Commit-Position: refs/heads/master@{#402043}
==========

[commit-bot: I haz the power, 2016-06-25 01:52:15]

Patchset 2 (id:??) landed as
https://crrev.com/292962a4de3a928fbc25539ab557169b86e89e88
Cr-Commit-Position: refs/heads/master@{#402043}