bluetooth: Avoid use of lambda to work around clang bug.

device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
@@ skipping 380 matching lines @@
   std::vector<uint8_t> empty_vector;
   SimulateGattCharacteristicRead(characteristic1_, empty_vector);
 
   EXPECT_EQ(1, gatt_read_characteristic_attempts_);
   EXPECT_EQ(test_vector, last_read_value_);
   EXPECT_EQ(test_vector, characteristic1_->GetValue());
 }
 #endif  // defined(OS_ANDROID) || defined(OS_WIN)
 
 #if defined(OS_ANDROID) || defined(OS_WIN)
+// Callback that make sure GattCharacteristicValueChanged has been called
+// before the callback runs.
+static void test_callback(

[ortuno, 2016/06/25 00:19:36]

Since this is no longer a lambda you can remove the cast to function pointer in
base::Bind on line 421, right?

[pcc1, 2016/06/25 00:26:39]

Done.

+    BluetoothRemoteGattCharacteristic::ValueCallback callback,
+    const TestBluetoothAdapterObserver& callback_observer,
+    const std::vector<uint8_t>& value) {
+  EXPECT_EQ(1, callback_observer.gatt_characteristic_value_changed_count());
+  callback.Run(value);
+}
+
 // Tests that ReadRemoteCharacteristic results in a
 // GattCharacteristicValueChanged call.
 TEST_F(BluetoothRemoteGattCharacteristicTest,
        ReadRemoteCharacteristic_GattCharacteristicValueChanged) {
   ASSERT_NO_FATAL_FAILURE(FakeCharacteristicBoilerplate(
       BluetoothRemoteGattCharacteristic::PROPERTY_READ));
 
   TestBluetoothAdapterObserver observer(adapter_);
 
-  // Callback that make sure GattCharacteristicValueChanged has been called
-  // before the callback runs.
-  auto test_callback = [](
-      BluetoothRemoteGattCharacteristic::ValueCallback callback,
-      const TestBluetoothAdapterObserver& callback_observer,
-      const std::vector<uint8_t>& value) {
-    EXPECT_EQ(1, callback_observer.gatt_characteristic_value_changed_count());
-    callback.Run(value);
-  };
-
   characteristic1_->ReadRemoteCharacteristic(
       base::Bind((void (*)(BluetoothRemoteGattCharacteristic::ValueCallback,
                            const TestBluetoothAdapterObserver&,
                            const std::vector<uint8_t>&))test_callback,
                  GetReadValueCallback(Call::EXPECTED),
                  base::ConstRef(observer)),
       GetGattErrorCallback(Call::NOT_EXPECTED));
 
   std::vector<uint8_t> test_vector = {0, 1, 2, 3, 4, 0xf, 0xf0, 0xff};
   SimulateGattCharacteristicRead(characteristic1_, test_vector);
@@ skipping 850 matching lines @@
   EXPECT_EQ(1u, characteristic1_->GetDescriptorsByUUID(id2).size());
   EXPECT_EQ(2u, characteristic2_->GetDescriptorsByUUID(id3).size());
 
   EXPECT_EQ(0u, characteristic2_->GetDescriptorsByUUID(id1).size());
   EXPECT_EQ(0u, characteristic2_->GetDescriptorsByUUID(id2).size());
   EXPECT_EQ(0u, characteristic1_->GetDescriptorsByUUID(id3).size());
 }
 #endif  // defined(OS_ANDROID) || defined(OS_WIN)
 
 }  // namespace device