Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2089053002: Delay to apply |checked| attribute only if the document has form state to be restored. (Closed)

Created:
4 years, 6 months ago by tkent
Modified:
4 years, 6 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delay to apply |checked| attribute only if the document has form state to be restored. We delayed to apply |checked| attribute of INPUT element until finishParsingChildren() in order to restore radio button group state correctly. Web authors can't observe this delay in HTML documents because INPUT can't have children, but could observe it in XHTML documents. We don't need to delay it if we don't restore form state. This CL makes a WPT test passing. BUG=594087 Committed: https://crrev.com/be6ceb18476472a0a87345b86ed8fd7c2674ef00 Cr-Commit-Position: refs/heads/master@{#401576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
D third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-input-element/checked-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/FormController.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FormController.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tkent
Keishi, would you review this please?
4 years, 6 months ago (2016-06-22 02:21:06 UTC) #2
keishi
LGTM
4 years, 6 months ago (2016-06-23 09:26:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089053002/1
4 years, 6 months ago (2016-06-23 09:27:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 10:40:35 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 10:42:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be6ceb18476472a0a87345b86ed8fd7c2674ef00
Cr-Commit-Position: refs/heads/master@{#401576}

Powered by Google App Engine
This is Rietveld 408576698