Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2089053002: Delay to apply |checked| attribute only if the document has form state to be restored. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 678 matching lines...) Expand 10 before | Expand all | Expand 10 after
689 m_needsToUpdateViewValue = true; 689 m_needsToUpdateViewValue = true;
690 setNeedsValidityCheck(); 690 setNeedsValidityCheck();
691 m_valueAttributeWasUpdatedAfterParsing = !m_parsingInProgress; 691 m_valueAttributeWasUpdatedAfterParsing = !m_parsingInProgress;
692 m_inputType->warnIfValueIsInvalidAndElementIsVisible(value); 692 m_inputType->warnIfValueIsInvalidAndElementIsVisible(value);
693 m_inputTypeView->valueAttributeChanged(); 693 m_inputTypeView->valueAttributeChanged();
694 } else if (name == checkedAttr) { 694 } else if (name == checkedAttr) {
695 // Another radio button in the same group might be checked by state 695 // Another radio button in the same group might be checked by state
696 // restore. We shouldn't call setChecked() even if this has the checked 696 // restore. We shouldn't call setChecked() even if this has the checked
697 // attribute. So, delay the setChecked() call until 697 // attribute. So, delay the setChecked() call until
698 // finishParsingChildren() is called if parsing is in progress. 698 // finishParsingChildren() is called if parsing is in progress.
699 if (!m_parsingInProgress && !m_dirtyCheckedness) { 699 if ((!m_parsingInProgress || !document().formController().hasFormStates( )) && !m_dirtyCheckedness) {
700 setChecked(!value.isNull()); 700 setChecked(!value.isNull());
701 m_dirtyCheckedness = false; 701 m_dirtyCheckedness = false;
702 } 702 }
703 pseudoStateChanged(CSSSelector::PseudoDefault); 703 pseudoStateChanged(CSSSelector::PseudoDefault);
704 } else if (name == maxlengthAttr) { 704 } else if (name == maxlengthAttr) {
705 parseMaxLengthAttribute(value); 705 parseMaxLengthAttribute(value);
706 } else if (name == minlengthAttr) { 706 } else if (name == minlengthAttr) {
707 parseMinLengthAttribute(value); 707 parseMinLengthAttribute(value);
708 } else if (name == sizeAttr) { 708 } else if (name == sizeAttr) {
709 int oldSize = m_size; 709 int oldSize = m_size;
(...skipping 1196 matching lines...) Expand 10 before | Expand all | Expand 10 after
1906 void HTMLInputElement::ensurePrimaryContent() 1906 void HTMLInputElement::ensurePrimaryContent()
1907 { 1907 {
1908 m_inputTypeView->ensurePrimaryContent(); 1908 m_inputTypeView->ensurePrimaryContent();
1909 } 1909 }
1910 1910
1911 bool HTMLInputElement::hasFallbackContent() const 1911 bool HTMLInputElement::hasFallbackContent() const
1912 { 1912 {
1913 return m_inputTypeView->hasFallbackContent(); 1913 return m_inputTypeView->hasFallbackContent();
1914 } 1914 }
1915 } // namespace blink 1915 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698