Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2089023002: Promotes remaining global window manager state into WindowManagerState (Closed)

Created:
4 years, 6 months ago by sky
Modified:
4 years, 6 months ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Promotes remaining global window manager state into WindowManagerState The non-global bits, which is basically just creation of the ServerWindow for per display window manager roots is now in WindowManagerDisplayRoot. I moved GlobalWindowManagerState back into WindowManagerState. BUG=611563 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/b6815d705e84fdf739222e40e5b394a0760b3a6d Cr-Commit-Position: refs/heads/master@{#401429}

Patch Set 1 #

Patch Set 2 : cleanup and merge #

Patch Set 3 : moar cleanup #

Patch Set 4 : cleanup #

Patch Set 5 : override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+733 lines, -657 lines) Patch
M components/mus/mus_app.cc View 1 4 chunks +18 lines, -5 lines 0 comments Download
M components/mus/ws/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/cursor_unittest.cc View 1 3 chunks +11 lines, -7 lines 0 comments Download
M components/mus/ws/display.h View 1 2 6 chunks +28 lines, -23 lines 0 comments Download
M components/mus/ws/display.cc View 1 2 9 chunks +76 lines, -125 lines 0 comments Download
M components/mus/ws/display_manager.h View 1 2 4 chunks +18 lines, -20 lines 0 comments Download
M components/mus/ws/display_manager.cc View 4 chunks +35 lines, -20 lines 0 comments Download
M components/mus/ws/display_manager_delegate.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/mus/ws/display_unittest.cc View 10 chunks +47 lines, -33 lines 0 comments Download
M components/mus/ws/event_dispatcher.h View 5 chunks +3 lines, -5 lines 0 comments Download
M components/mus/ws/event_dispatcher.cc View 9 chunks +20 lines, -12 lines 0 comments Download
M components/mus/ws/event_dispatcher_delegate.h View 3 chunks +12 lines, -3 lines 0 comments Download
M components/mus/ws/event_dispatcher_unittest.cc View 4 chunks +11 lines, -5 lines 0 comments Download
D components/mus/ws/global_window_manager_state.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/mus/ws/global_window_manager_state.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M components/mus/ws/test_utils.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/mus/ws/user_display_manager_unittest.cc View 1 4 chunks +3 lines, -4 lines 0 comments Download
M components/mus/ws/user_id_tracker_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
A components/mus/ws/window_manager_display_root.h View 1 2 3 1 chunk +62 lines, -0 lines 0 comments Download
A components/mus/ws/window_manager_display_root.cc View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
M components/mus/ws/window_manager_state.h View 1 2 3 4 7 chunks +42 lines, -43 lines 0 comments Download
M components/mus/ws/window_manager_state.cc View 1 2 12 chunks +117 lines, -64 lines 0 comments Download
M components/mus/ws/window_manager_state_unittest.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
M components/mus/ws/window_manager_window_tree_factory.h View 1 2 3 4 chunks +0 lines, -10 lines 0 comments Download
M components/mus/ws/window_manager_window_tree_factory.cc View 1 5 chunks +4 lines, -33 lines 0 comments Download
M components/mus/ws/window_manager_window_tree_factory_set.h View 3 chunks +3 lines, -7 lines 0 comments Download
M components/mus/ws/window_manager_window_tree_factory_set.cc View 1 2 chunks +7 lines, -11 lines 0 comments Download
M components/mus/ws/window_server.h View 1 3 chunks +2 lines, -6 lines 0 comments Download
M components/mus/ws/window_server.cc View 1 7 chunks +47 lines, -43 lines 0 comments Download
M components/mus/ws/window_tree.h View 1 5 chunks +14 lines, -13 lines 0 comments Download
M components/mus/ws/window_tree.cc View 1 18 chunks +96 lines, -76 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 6 months ago (2016-06-22 16:58:47 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 6 months ago (2016-06-22 20:47:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089023002/80001
4 years, 6 months ago (2016-06-22 20:57:14 UTC) #4
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-22 22:09:50 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 22:11:57 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b6815d705e84fdf739222e40e5b394a0760b3a6d
Cr-Commit-Position: refs/heads/master@{#401429}

Powered by Google App Engine
This is Rietveld 408576698