third_party/WebKit/LayoutTests/intersection-observer/root-margin.html - Issue 2088963002: IntersectionObserver constructor: fail on invalid rootMargin syntax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/intersection-observer/root-margin.html

Issue 2088963002: IntersectionObserver constructor: fail on invalid rootMargin syntax. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Simplify loop condition Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions-expected.txt ('k') | third_party/WebKit/LayoutTests/intersection-observer/root-margin-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/intersection-observer/root-margin.html

diff --git a/third_party/WebKit/LayoutTests/intersection-observer/root-margin.html b/third_party/WebKit/LayoutTests/intersection-observer/root-margin.html

index 3a62f53245f418b3741a5d8865086fed9431f783..c11458c3d5fa3316a307a5dfe9c1e8acb574ece7 100644

--- a/third_party/WebKit/LayoutTests/intersection-observer/root-margin.html

+++ b/third_party/WebKit/LayoutTests/intersection-observer/root-margin.html

@@ -21,7 +21,6 @@ var observer = new IntersectionObserver(

shouldNotThrow("new IntersectionObserver(c => {}, { rootMargin: '1.4px' })");

shouldNotThrow("new IntersectionObserver(c => {}, { rootMargin: '1.4px 2px' })");

shouldNotThrow("new IntersectionObserver(c => {}, { rootMargin: '1.4px 2px 3%' })");

-shouldNotThrow("new IntersectionObserver(c => {}, { rootMargin: '1.4px 2px 3% 40px junk junk junk' })");

onload = function() {

observer.observe(target);