third_party/WebKit/LayoutTests/intersection-observer/root-margin-expected.txt - Issue 2088963002: IntersectionObserver constructor: fail on invalid rootMargin syntax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/intersection-observer/root-margin-expected.txt

Issue 2088963002: IntersectionObserver constructor: fail on invalid rootMargin syntax. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Simplify loop condition Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/root-margin.html ('k') | third_party/WebKit/Source/core/dom/IntersectionObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/intersection-observer/root-margin-expected.txt

diff --git a/third_party/WebKit/LayoutTests/intersection-observer/root-margin-expected.txt b/third_party/WebKit/LayoutTests/intersection-observer/root-margin-expected.txt

index a88ff826869e155c665b8ba6c73a1b5af25dcbe4..09806a0ae3f3d9ba83e9f3b3f984b5d9e788e036 100644

--- a/third_party/WebKit/LayoutTests/intersection-observer/root-margin-expected.txt

+++ b/third_party/WebKit/LayoutTests/intersection-observer/root-margin-expected.txt

@@ -6,7 +6,6 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE

PASS new IntersectionObserver(c => {}, { rootMargin: '1.4px' }) did not throw exception.

PASS new IntersectionObserver(c => {}, { rootMargin: '1.4px 2px' }) did not throw exception.

PASS new IntersectionObserver(c => {}, { rootMargin: '1.4px 2px 3%' }) did not throw exception.

-PASS new IntersectionObserver(c => {}, { rootMargin: '1.4px 2px 3% 40px junk junk junk' }) did not throw exception.

PASS entries.length is 0

PASS entries.length is 1