Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 208893007: DevTools: InspectorHistory actions become refcounted. (Closed)

Created:
6 years, 9 months ago by lushnikov
Modified:
6 years, 9 months ago
Reviewers:
apavlov, vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: InspectorHistory actions become refcounted. This patch makes InspectorHistory::Action class to be refcounted. This helps to get results of completed operations in InspectorHistory without possibility of use-after-free (this patch fixes two of this cases). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -30 lines) Patch
M Source/core/inspector/DOMEditor.cpp View 3 chunks +12 lines, -13 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 6 chunks +8 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorHistory.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorHistory.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
lushnikov
Please take a look
6 years, 9 months ago (2014-03-25 15:47:35 UTC) #1
apavlov
lgtm, according to pfeldman
6 years, 9 months ago (2014-03-25 16:13:53 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 9 months ago (2014-03-26 07:44:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/208893007/1
6 years, 9 months ago (2014-03-26 07:44:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 08:54:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-26 08:54:35 UTC) #6
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 9 months ago (2014-03-26 12:30:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/208893007/1
6 years, 9 months ago (2014-03-26 12:31:08 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 13:19:53 UTC) #9
Message was sent while issue was closed.
Change committed as 170054

Powered by Google App Engine
This is Rietveld 408576698