Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: Source/core/inspector/InspectorHistory.h

Issue 208893007: DevTools: InspectorHistory actions become refcounted. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/InspectorCSSAgent.cpp ('k') | Source/core/inspector/InspectorHistory.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef InspectorHistory_h 31 #ifndef InspectorHistory_h
32 #define InspectorHistory_h 32 #define InspectorHistory_h
33 33
34 #include "wtf/OwnPtr.h" 34 #include "wtf/RefPtr.h"
35 #include "wtf/Vector.h" 35 #include "wtf/Vector.h"
36 #include "wtf/text/WTFString.h" 36 #include "wtf/text/WTFString.h"
37 37
38 namespace WebCore { 38 namespace WebCore {
39 39
40 class ExceptionState; 40 class ExceptionState;
41 41
42 class InspectorHistory FINAL { 42 class InspectorHistory FINAL {
43 WTF_MAKE_NONCOPYABLE(InspectorHistory); WTF_MAKE_FAST_ALLOCATED; 43 WTF_MAKE_NONCOPYABLE(InspectorHistory); WTF_MAKE_FAST_ALLOCATED;
44 public: 44 public:
45 class Action { 45 class Action : public RefCounted<Action> {
46 WTF_MAKE_FAST_ALLOCATED; 46 WTF_MAKE_FAST_ALLOCATED;
47 public: 47 public:
48 Action(const String& name); 48 Action(const String& name);
49 virtual ~Action(); 49 virtual ~Action();
50 virtual String toString(); 50 virtual String toString();
51 51
52 virtual String mergeId(); 52 virtual String mergeId();
53 virtual void merge(PassOwnPtr<Action>); 53 virtual void merge(PassRefPtr<Action>);
54 54
55 virtual bool perform(ExceptionState&) = 0; 55 virtual bool perform(ExceptionState&) = 0;
56 56
57 virtual bool undo(ExceptionState&) = 0; 57 virtual bool undo(ExceptionState&) = 0;
58 virtual bool redo(ExceptionState&) = 0; 58 virtual bool redo(ExceptionState&) = 0;
59 59
60 virtual bool isUndoableStateMark(); 60 virtual bool isUndoableStateMark();
61 private: 61 private:
62 String m_name; 62 String m_name;
63 }; 63 };
64 64
65 InspectorHistory(); 65 InspectorHistory();
66 66
67 bool perform(PassOwnPtr<Action>, ExceptionState&); 67 bool perform(PassRefPtr<Action>, ExceptionState&);
68 void markUndoableState(); 68 void markUndoableState();
69 69
70 bool undo(ExceptionState&); 70 bool undo(ExceptionState&);
71 bool redo(ExceptionState&); 71 bool redo(ExceptionState&);
72 void reset(); 72 void reset();
73 73
74 private: 74 private:
75 Vector<OwnPtr<Action> > m_history; 75 Vector<RefPtr<Action> > m_history;
76 size_t m_afterLastActionIndex; 76 size_t m_afterLastActionIndex;
77 }; 77 };
78 78
79 79
80 } // namespace WebCore 80 } // namespace WebCore
81 81
82 #endif // !defined(InspectorHistory_h) 82 #endif // !defined(InspectorHistory_h)
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorCSSAgent.cpp ('k') | Source/core/inspector/InspectorHistory.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698