chrome/android/java/res/values/dimens.xml - Issue 2088793004: NTP, change the card elevation from setElevation to a 9 patch file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 2088793004: NTP, change the card elevation from setElevation to a 9 patch file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Zine card elevetion from setElevation to 9 patch files Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/new_tab_page_status_card.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/values/dimens.xml

diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml

index 2ef6a2d4ca8a278256fa1e15991f5c32af62ad69..0f2e82e359e11467b2e9ceeb3e1eb4cad172e507 100644

--- a/chrome/android/java/res/values/dimens.xml

+++ b/chrome/android/java/res/values/dimens.xml

@@ -287,7 +287,7 @@

- <dimen name="snippets_vertical_spacing">1dp</dimen>

+ <dimen name="snippets_card_adjust_9_patch">2dp</dimen>

Bernhard Bauer 2016/06/29 11:22:27 Nit: Could we call this |snippets_card_9_patch_adj

mcwilliams 2016/06/29 14:15:55 Done.