chrome/android/java/res/values/dimens.xml - Issue 2088793004: NTP, change the card elevation from setElevation to a 9 patch file

Side by Side Diff: chrome/android/java/res/values/dimens.xml

Issue 2088793004: NTP, change the card elevation from setElevation to a 9 patch file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Zine card elevetion from setElevation to 9 patch files Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/new_tab_page_status_card.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <resources>	6 <resources>

7 <!-- Connection info popup dimensions -->	7 <!-- Connection info popup dimensions -->

8 <dimen name="connection_info_padding_wide">24dp</dimen>	8 <dimen name="connection_info_padding_wide">24dp</dimen>

9 <dimen name="connection_info_padding_thin">16dp</dimen>	9 <dimen name="connection_info_padding_thin">16dp</dimen>

10	10

(...skipping 269 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
280 <dimen name="ntp_search_box_material_padding_top">3dp</dimen>	280 <dimen name="ntp_search_box_material_padding_top">3dp</dimen>

281 <dimen name="ntp_search_box_material_padding_bottom">3dp</dimen>	281 <dimen name="ntp_search_box_material_padding_bottom">3dp</dimen>

282 <dimen name="ntp_search_box_material_padding_left">2dp</dimen>	282 <dimen name="ntp_search_box_material_padding_left">2dp</dimen>

283 <dimen name="ntp_search_box_material_padding_right">2dp</dimen>	283 <dimen name="ntp_search_box_material_padding_right">2dp</dimen>

284 <dimen name="ntp_list_item_padding">16dp</dimen>	284 <dimen name="ntp_list_item_padding">16dp</dimen>

285 <dimen name="ntp_list_item_min_height">48dp</dimen>	285 <dimen name="ntp_list_item_min_height">48dp</dimen>

286 <dimen name="ntp_list_item_text_size">16sp</dimen>	286 <dimen name="ntp_list_item_text_size">16sp</dimen>

287 <dimen name="ntp_shadow_height">9dp</dimen>	287 <dimen name="ntp_shadow_height">9dp</dimen>

288 <dimen name="snippets_thumbnail_size">72dp</dimen>	288 <dimen name="snippets_thumbnail_size">72dp</dimen>

289 <dimen name="snippets_padding_and_peeking_card_height">16dp</dimen>	289 <dimen name="snippets_padding_and_peeking_card_height">16dp</dimen>

290 <dimen name="snippets_vertical_spacing">1dp</dimen>	290 <dimen name="snippets_card_adjust_9_patch">2dp</dimen>
	Bernhard Bauer 2016/06/29 11:22:27 Nit: Could we call this \|snippets_card_9_patch_adj Nit: Could we call this \|snippets_card_9_patch_adjustment\| so it's consistent with the variable? mcwilliams 2016/06/29 14:15:55 Done. Show quoted text On 2016/06/29 11:22:27, Bernhard Bauer wrote: > Nit: Could we call this \|snippets_card_9_patch_adjustment\| so it's consistent > with the variable? Done.
291 <dimen name="snippets_article_header_height">40dp</dimen>	291 <dimen name="snippets_article_header_height">40dp</dimen>

292 <dimen name="snippets_card_elevation">2dp</dimen>	292 <dimen name="snippets_card_elevation">2dp</dimen>

293	293

294 <!-- Interests page -->	294 <!-- Interests page -->

295 <dimen name="ntp_interest_item_text_size">20sp</dimen>	295 <dimen name="ntp_interest_item_text_size">20sp</dimen>

296 <dimen name="ntp_interest_item_min_height">180dp</dimen>	296 <dimen name="ntp_interest_item_min_height">180dp</dimen>

297 <dimen name="ntp_interest_item_image_size">120dp</dimen>	297 <dimen name="ntp_interest_item_image_size">120dp</dimen>

298 <dimen name="ntp_interest_item_image_text_size">20sp</dimen>	298 <dimen name="ntp_interest_item_image_text_size">20sp</dimen>

299	299

300 <!-- Recent tabs page -->	300 <!-- Recent tabs page -->

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
359 <dimen name="payments_section_logo_height">36dp</dimen>	359 <dimen name="payments_section_logo_height">36dp</dimen>

360 <dimen name="payments_section_logo_width">56dp</dimen>	360 <dimen name="payments_section_logo_width">56dp</dimen>

361 <dimen name="payments_section_add_button_height">48dp</dimen>	361 <dimen name="payments_section_add_button_height">48dp</dimen>

362 <dimen name="payments_ui_max_dialog_width">0dp</dimen>	362 <dimen name="payments_ui_max_dialog_width">0dp</dimen>

363 <dimen name="payments_ui_translation">100dp</dimen>	363 <dimen name="payments_ui_translation">100dp</dimen>

364	364

365 <!-- Dialog dimensions.	365 <!-- Dialog dimensions.

366 https://www.google.com/design/spec/components/dialogs.html#dialogs-simp le-dialogs -->	366 https://www.google.com/design/spec/components/dialogs.html#dialogs-simp le-dialogs -->

367 <dimen name="dialog_width_unit">56dp</dimen> <!-- MD dialog widths are mult iples of this. -->	367 <dimen name="dialog_width_unit">56dp</dimen> <!-- MD dialog widths are mult iples of this. -->

368 </resources>	368 </resources>

OLD	NEW