Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/ipc/quads.mojom

Issue 2088603002: Implement RenderPass StructTraits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Dana's comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/ipc/quads_struct_traits.h » ('j') | cc/ipc/quads_struct_traits.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/ipc/quads.mojom
diff --git a/cc/ipc/quads.mojom b/cc/ipc/quads.mojom
index a5f3888e10dc013d0ead5ac40f48066a933363e1..3b7ad0ca0b7391a8ea4bc2d184f841949fe76dd5 100644
--- a/cc/ipc/quads.mojom
+++ b/cc/ipc/quads.mojom
@@ -124,7 +124,11 @@ struct DrawQuad {
// Index into the containing pass' shared quad state array which has state
// (transforms etc) shared by multiple quads.
- uint32 shared_quad_state_index;
+ // TODO(fsamuel): This is not currently used because we store the
+ // indicies to SharedQuadStates in a separate array. This is more expensive
+ // than storing them inline here, but we need support for context propagation
+ // in Mojo StructTraits in order to store the sqs index here.
+ //uint32 shared_quad_state_index;
// Only one of the following will be set, depending on the material.
DebugBorderQuadState? debug_border_quad_state;
« no previous file with comments | « no previous file | cc/ipc/quads_struct_traits.h » ('j') | cc/ipc/quads_struct_traits.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698