Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2088363002: Revert of [Chromoting] Disable building 64bit chromoting.msi file. (Closed)

Created:
4 years, 6 months ago by dgozman
Modified:
4 years, 6 months ago
Reviewers:
Hzj_jie, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org, Jamie
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromoting] Disable building 64bit chromoting.msi file. (patchset #2 id:60001 of https://codereview.chromium.org/2073943002/ ) Reason for revert: Breaks the build: https://bugs.chromium.org/p/chromium/issues/detail?id=622443 Original issue's description: > [Chromoting] Disable building 64bit chromoting.msi file. > > A recent bug http://crbug.com/613001 has been reported by AJ, which is due to a > bad signing parameter we are using. It causes the 64 bit signed MSI file won't > be able to execute correctly in curtain mode. > Since we do not release 64bit msi, we should not spend time to build it. > > BUG= > > Committed: https://crrev.com/b4ed437b70ea66dc21fc7aaf856d9524e24a02b3 > Cr-Commit-Position: refs/heads/master@{#401031} TBR=joedow@chromium.org,zijiehe@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= NOTRY=true Committed: https://crrev.com/10868cf662bacfbb13b376c8baf3858ea7286528 Cr-Commit-Position: refs/heads/master@{#401487}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -29 lines) Patch
M remoting/host/BUILD.gn View 1 chunk +23 lines, -26 lines 0 comments Download
M remoting/remoting_host_win.gypi View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dgozman
Created Revert of [Chromoting] Disable building 64bit chromoting.msi file.
4 years, 6 months ago (2016-06-23 00:16:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088363002/1
4 years, 6 months ago (2016-06-23 00:17:34 UTC) #3
dgozman
NOTRY so that breakage does not affect Canary.
4 years, 6 months ago (2016-06-23 00:46:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088363002/1
4 years, 6 months ago (2016-06-23 00:47:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 00:52:59 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/10868cf662bacfbb13b376c8baf3858ea7286528 Cr-Commit-Position: refs/heads/master@{#401487}
4 years, 6 months ago (2016-06-23 00:55:15 UTC) #12
Hzj_jie
4 years, 6 months ago (2016-06-23 01:13:12 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2090873002/ by zijiehe@chromium.org.

The reason for reverting is: Try to reproduce the build break..

Powered by Google App Engine
This is Rietveld 408576698