Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2088323002: Update some WebCrypto comments to better describe the threading reality. (Closed)

Created:
4 years, 6 months ago by eroman
Modified:
4 years, 6 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update some WebCrypto comments to better describe the threading reality. Committed: https://crrev.com/984ead6c20ef098f8af6b4da25600e01bd3303ef Cr-Commit-Position: refs/heads/master@{#401479}

Patch Set 1 #

Patch Set 2 : fix a typo "mutated" --> "mutate" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M components/webcrypto/blink_key_handle.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M components/webcrypto/webcrypto_impl.cc View 2 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
eroman
Thanks for chatting with me about the boringssl threading! I have updated some comments in ...
4 years, 6 months ago (2016-06-22 22:42:53 UTC) #2
davidben
lgtm. PS: If you want to update the various BoringSSL headers on thread-safety of EVP_PKEY ...
4 years, 6 months ago (2016-06-22 23:02:33 UTC) #3
eroman
On 2016/06/22 23:02:33, davidben wrote: > lgtm. > > PS: If you want to update ...
4 years, 6 months ago (2016-06-22 23:31:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088323002/20001
4 years, 6 months ago (2016-06-22 23:32:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 00:25:42 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 00:28:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/984ead6c20ef098f8af6b4da25600e01bd3303ef
Cr-Commit-Position: refs/heads/master@{#401479}

Powered by Google App Engine
This is Rietveld 408576698