Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2088163002: content/public/common should depend on the mojo_bindings target (Closed)

Created:
4 years, 6 months ago by Mostyn Bramley-Moore
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content/public/common should depend on the mojo_bindings target Rather than the mojo_bindings_mojom target, which exports sources, and causes multiple definition errors in component builds. Followup to https://codereview.chromium.org/2089823002 BUG=622076 TBR=jam@chromium.org,rockot@chromium.org Committed: https://crrev.com/7279505c6d3be5eb212e81a3b769d88e76d413e7 Cr-Commit-Position: refs/heads/master@{#401230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/content_common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088163002/1
4 years, 6 months ago (2016-06-22 07:52:41 UTC) #2
Mostyn Bramley-Moore
@jam, rockot: please take a look at this fixup. Without this, gyp component builds fail ...
4 years, 6 months ago (2016-06-22 07:53:52 UTC) #4
Mostyn Bramley-Moore
The blink side looks OK, since it uses a header target.
4 years, 6 months ago (2016-06-22 08:01:37 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 08:30:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088163002/1
4 years, 6 months ago (2016-06-22 08:32:42 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 08:36:56 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 08:38:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7279505c6d3be5eb212e81a3b769d88e76d413e7
Cr-Commit-Position: refs/heads/master@{#401230}

Powered by Google App Engine
This is Rietveld 408576698