Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 2089823002: Fix missing dependency for content/public/common on blink mojom (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing dependency for content/public/common on blink mojom content/public/common exposes generated headers from this target through its own headers but this dependency was not properly expressed in either GN or GYP rules. Fixed. BUG=622076 TBR=jam@chromium.org Committed: https://crrev.com/a8ea5fa23b6d85b34ffa5db9379155e7ab0ea286 Cr-Commit-Position: refs/heads/master@{#401182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/content_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Ken Rockot(use gerrit already)
4 years, 6 months ago (2016-06-21 22:04:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089823002/1
4 years, 6 months ago (2016-06-21 22:04:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/242916)
4 years, 6 months ago (2016-06-22 01:19:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089823002/1
4 years, 6 months ago (2016-06-22 01:29:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 02:51:53 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 02:55:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8ea5fa23b6d85b34ffa5db9379155e7ab0ea286
Cr-Commit-Position: refs/heads/master@{#401182}

Powered by Google App Engine
This is Rietveld 408576698