Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5189)

Unified Diff: chrome_elf/BUILD.gn

Issue 2088133002: Switch chrome_elf exception handling from breakpad to crashpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update commments and attempt to fix dependency failure Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_elf/BUILD.gn
diff --git a/chrome_elf/BUILD.gn b/chrome_elf/BUILD.gn
index 8d859f0fbb775332a935692f3e207544313dc8c7..f4d15a636aed7bdb7f7d40cd28e1775b25a0d48d 100644
--- a/chrome_elf/BUILD.gn
+++ b/chrome_elf/BUILD.gn
@@ -32,10 +32,11 @@ shared_library("chrome_elf") {
"chrome_elf.def",
"chrome_elf_main.cc",
"chrome_elf_main.h",
+ "crashpad_helper.cc",
+ "crashpad_helper.h",
]
deps = [
":blacklist",
- ":breakpad",
":chrome_elf_manifest",
":chrome_elf_resources",
":common",
@@ -44,7 +45,8 @@ shared_library("chrome_elf") {
"//chrome/install_static:install_static_util",
"//components/crash/content/app",
"//components/crash/core/common",
- "//content/public/common:result_codes",
+ "//content/public/common:result_codes",
+ "//third_party/crashpad/crashpad/client:client",
]
configs += [ "//build/config/win:windowed" ]
configs -= [ "//build/config/win:console" ]
@@ -87,21 +89,6 @@ source_set("common") {
]
}
-source_set("breakpad") {
- include_dirs = [ "$target_gen_dir" ]
- sources = [
- "breakpad.cc",
- "breakpad.h",
- ]
- deps = [
- ":common",
- "//base",
- "//breakpad:breakpad_handler",
- "//chrome/common:version_header",
- "//chrome/install_static:install_static_util",
- ]
-}
-
source_set("dll_hash") {
deps = [
"//base",
@@ -129,16 +116,19 @@ static_library("blacklist") {
"blacklist/blacklist.h",
"blacklist/blacklist_interceptions.cc",
"blacklist/blacklist_interceptions.h",
+ "crashpad_helper.cc",
scottmg 2016/06/22 19:38:07 I don't think this should be in both blacklist and
ananta 2016/06/22 21:08:20 Yeah. Moved the files to the blacklist folder.
+ "crashpad_helper.h",
]
public_deps = [
"//sandbox",
]
deps = [
- ":breakpad",
":common",
":constants",
"//base",
"//chrome/install_static:install_static_util",
+ "//components/crash/content/app",
+ "//third_party/crashpad/crashpad/client:client",
]
}

Powered by Google App Engine
This is Rietveld 408576698