Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome_elf/chrome_elf.gyp

Issue 2088133002: Switch chrome_elf exception handling from breakpad to crashpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update commments and attempt to fix dependency failure Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_elf/chrome_elf.gyp
diff --git a/chrome_elf/chrome_elf.gyp b/chrome_elf/chrome_elf.gyp
index 87d16f22a754d772bcfe4ce02468b99c535e8eda..96af2dd9fab74308e850e4c0e418da9e379a7b75 100644
--- a/chrome_elf/chrome_elf.gyp
+++ b/chrome_elf/chrome_elf.gyp
@@ -37,13 +37,14 @@
'chrome_elf.def',
'chrome_elf_main.cc',
'chrome_elf_main.h',
+ 'crashpad_helper.cc',
scottmg 2016/06/22 19:38:07 Same for gyp.
+ 'crashpad_helper.h',
'../chrome/app/chrome_crash_reporter_client_win.cc',
'../chrome/app/chrome_crash_reporter_client_win.h',
'<(SHARED_INTERMEDIATE_DIR)/chrome_elf/chrome_elf_version.rc',
],
'dependencies': [
'blacklist',
- 'chrome_elf_breakpad',
'chrome_elf_resources',
'../chrome/chrome.gyp:install_static_util',
'../components/components.gyp:crash_component',
@@ -133,24 +134,6 @@
'thunk_getter.h',
],
},
- {
- 'target_name': 'chrome_elf_breakpad',
- 'type': 'static_library',
- 'include_dirs': [
- '..',
- '<(SHARED_INTERMEDIATE_DIR)',
- ],
- 'sources': [
- 'breakpad.cc',
- 'breakpad.h',
- ],
- 'dependencies': [
- 'chrome_elf_common',
- '../breakpad/breakpad.gyp:breakpad_handler',
- '../chrome/common_constants.gyp:version_header',
- '../chrome/chrome.gyp:install_static_util',
- ],
- },
], # targets
'conditions': [
['test_isolation_mode != "noop"', {

Powered by Google App Engine
This is Rietveld 408576698