Issue 2088053002: Split to use two different ID for the two different checkbox in two different subview. Currently th…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2088053002: Split to use two different ID for the two different checkbox in two different subview. Currently th… (Closed)

Created:
4 years, 6 months ago by groby-ooo-7-16

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

More Reviews

Description

Split to use two different ID for the two different checkbox in two different subview. Currently the code always listen to the checkbox created in the advanced view. so even if user click to check/uncheck the box in the before view, the code listen to the value of the checkbox inside the advanced view which was not shown to the user. BUG=620921 Review-Url: https://codereview.chromium.org/2074983003 Cr-Commit-Position: refs/heads/master@{#400797} (cherry picked from commit bf4dd975949936a88973a42df91639cec18d0d2e)

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -29 lines)			Patch
M	chrome/browser/ui/views/translate/translate_bubble_view.h	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/translate/translate_bubble_view.cc	View	10 chunks	+43 lines, -24 lines	0 comments	Download
M	chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

4 years, 6 months ago (2016-06-21 21:56:06 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
eb4f9b7d66ae62cb3e001b6a7149c9e8b95b1cb2.

Expand Messages | Collapse Messages