Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2919)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.h

Issue 2088053002: Split to use two different ID for the two different checkbox in two different subview. Currently th… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/translate/translate_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/translate/translate_bubble_view.h
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.h b/chrome/browser/ui/views/translate/translate_bubble_view.h
index 1042629d52f2710498ae46a64fb870d59baa5455..7bf9380609273e8eeb6b4eda8cdacf2ab89e79f7 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.h
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.h
@@ -211,6 +211,9 @@ class TranslateBubbleView : public LocationBarBubbleDelegateView,
// Creates the 'advanced' view. Caller takes ownership of the returned view.
views::View* CreateViewAdvanced();
+ // Get the current always translate checkbox
+ views::Checkbox* GetAlwaysTranslateCheckbox();
+
// Switches the view type.
void SwitchView(TranslateBubbleModel::ViewState view_state);
@@ -236,7 +239,8 @@ class TranslateBubbleView : public LocationBarBubbleDelegateView,
views::Combobox* source_language_combobox_;
views::Combobox* target_language_combobox_;
- views::Checkbox* always_translate_checkbox_;
+ views::Checkbox* before_always_translate_checkbox_;
+ views::Checkbox* advanced_always_translate_checkbox_;
views::LabelButton* advanced_cancel_button_;
views::LabelButton* advanced_done_button_;
@@ -252,6 +256,8 @@ class TranslateBubbleView : public LocationBarBubbleDelegateView,
// Whether the window is an incognito window.
const bool is_in_incognito_window_;
+ bool should_always_translate_;
+
std::unique_ptr<WebContentMouseHandler> mouse_handler_;
DISALLOW_COPY_AND_ASSIGN(TranslateBubbleView);
« no previous file with comments | « no previous file | chrome/browser/ui/views/translate/translate_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698