Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

Issue 2087953004: Switch v8 inspector to stl collections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Actually remove a value from the list Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
index ab04bb50a43a1170bc4fbcd8ae18aa743faa2432..ff44623e00865fb484a2e549b08d44078b0888c9 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
@@ -10,6 +10,8 @@
#include "platform/v8_inspector/V8DebuggerImpl.h"
#include "platform/v8_inspector/protocol/Debugger.h"
+#include <vector>
+
namespace blink {
class JavaScriptCallFrame;
@@ -148,7 +150,7 @@ public:
void reset();
// Interface for V8DebuggerImpl
- SkipPauseRequest didPause(v8::Local<v8::Context>, v8::Local<v8::Value> exception, const protocol::Vector<String16>& hitBreakpoints, bool isPromiseRejection);
+ SkipPauseRequest didPause(v8::Local<v8::Context>, v8::Local<v8::Value> exception, const std::vector<String16>& hitBreakpoints, bool isPromiseRejection);
void didContinue();
void didParseSource(const V8DebuggerParsedScript&);
bool v8AsyncTaskEventsEnabled() const;
@@ -191,7 +193,7 @@ private:
bool setBlackboxPattern(ErrorString*, const String16& pattern);
using ScriptsMap = protocol::HashMap<String16, V8DebuggerScript>;
- using BreakpointIdToDebuggerBreakpointIdsMap = protocol::HashMap<String16, protocol::Vector<String16>>;
+ using BreakpointIdToDebuggerBreakpointIdsMap = protocol::HashMap<String16, std::vector<String16>>;
using DebugServerBreakpointToBreakpointIdAndSourceMap = protocol::HashMap<String16, std::pair<String16, BreakpointSource>>;
using MuteBreakpoins = protocol::HashMap<String16, std::pair<String16, int>>;
@@ -231,10 +233,10 @@ private:
AsyncTaskToStackTrace m_asyncTaskStacks;
protocol::HashSet<void*> m_recurringTasks;
int m_maxAsyncCallStackDepth;
- protocol::Vector<void*> m_currentTasks;
- protocol::Vector<std::unique_ptr<V8StackTraceImpl>> m_currentStacks;
+ std::vector<void*> m_currentTasks;
+ std::vector<std::unique_ptr<V8StackTraceImpl>> m_currentStacks;
std::unique_ptr<V8Regex> m_blackboxPattern;
- protocol::HashMap<String16, protocol::Vector<std::pair<int, int>>> m_blackboxedPositions;
+ protocol::HashMap<String16, std::vector<std::pair<int, int>>> m_blackboxedPositions;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698