third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h - Issue 2087953004: Switch v8 inspector to stl collections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

Issue 2087953004: Switch v8 inspector to stl collections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually remove a value from the list Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

index 6f9693522eaba9ab282bee8638038ba59d55f7d4..959f8172ee31da5ed3e602de164a003648946da2 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

@@ -36,6 +36,8 @@

#include "platform/inspector_protocol/String16.h"

#include <v8.h>

+#include <vector>

namespace blink {

class JavaScriptCallFrame {

@@ -67,7 +69,7 @@ private:

v8::Global<v8::Object> m_callFrame;

};

-using JavaScriptCallFrames = protocol::Vector<std::unique_ptr<JavaScriptCallFrame>>;

+using JavaScriptCallFrames = std::vector<std::unique_ptr<JavaScriptCallFrame>>;

} // namespace blink