Issue 2087803004: Version 5.0.71.54 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2087803004: Version 5.0.71.54 (cherry-pick)

Created:
4 years, 6 months ago by thealphanerd

Modified:
4 years, 6 months ago

Reviewers:
ofrobots

CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., ulan, Michael Hablich

Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0

Target Ref:
refs/pending/branch-heads/5.0

Project:
v8

Visibility:
Public.

More Reviews

Description

Version 5.0.71.54 (cherry-pick) Merged 7dfb5beeec Fix 'typeof null' canonicalization in crankshaft R=ofrobots@google.com BUG=

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -7 lines)			Patch
M	include/v8-version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/crankshaft/hydrogen-instructions.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-opt-typeof-null.js	View	1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ofrobots

On 2016/06/21 18:12:03, thealphanerd wrote: superceded by: https://codereview.chromium.org/2088783002 which landed earlier today.

4 years, 6 months ago (2016-06-21 18:24:15 UTC) #2

thealphanerd

On 2016/06/21 18:24:15, ofrobots wrote: > On 2016/06/21 18:12:03, thealphanerd wrote: > > superceded by: ...

4 years, 6 months ago (2016-06-21 18:31:31 UTC) #3

ofrobots

4 years, 6 months ago (2016-06-22 16:22:11 UTC) #5

The merge process for V8 5.0 is undefined as it is no longer being maintained /
tested. I think it would be better to float this on Node side until the process
in https://github.com/nodejs/lts/issues/111 gets fleshed out.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages