Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 2088783002: Version 5.1.281.67 (cherry-pick) (Closed)

Created:
3 years, 1 month ago by Toon Verwaest
Modified:
3 years, 1 month ago
Reviewers:
Camillo Bruni
CC:
PaweĊ‚ Hajdan Jr., ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.1
Target Ref:
refs/pending/branch-heads/5.1
Project:
v8
Visibility:
Public.

Description

Version 5.1.281.67 (cherry-pick) Fix 'typeof null' canonicalization in crankshaft R=cbruni@chromium.org BUG=chromium:604033 Committed: https://chromium.googlesource.com/v8/v8/+/a9ddcde6dc81b605e1fbf43994144c911218792a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 2 chunks +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-opt-typeof-null.js View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
3 years, 1 month ago (2016-06-21 12:43:59 UTC) #1
Camillo Bruni
lgtm
3 years, 1 month ago (2016-06-21 12:44:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088783002/1
3 years, 1 month ago (2016-06-21 12:45:42 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 1 month ago (2016-06-21 12:45:44 UTC) #6
Toon Verwaest
3 years, 1 month ago (2016-06-21 12:51:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a9ddcde6dc81b605e1fbf43994144c911218792a.

Powered by Google App Engine
This is Rietveld 408576698