Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2087773002: DevTools: add CSS completion for contain property. (Closed)

Created:
4 years, 6 months ago by paulirish
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add CSS completion for contain property. BUG=561713 Committed: https://crrev.com/f2168263f19ab4f81c56d6258db7d9e6fa0b07fb Cr-Commit-Position: refs/heads/master@{#402216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
paulirish
ptal
4 years, 6 months ago (2016-06-21 09:27:44 UTC) #2
lushnikov
lgtm we should start using this in the devtools!
4 years, 5 months ago (2016-06-27 15:32:10 UTC) #3
paulirish
Yeah. It looks like "contain:content" doesn't give perf benefits. I tried out contain:strict in a ...
4 years, 5 months ago (2016-06-27 15:44:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2087773002/1
4 years, 5 months ago (2016-06-27 15:45:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 17:40:14 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 17:41:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2168263f19ab4f81c56d6258db7d9e6fa0b07fb
Cr-Commit-Position: refs/heads/master@{#402216}

Powered by Google App Engine
This is Rietveld 408576698