Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: build/config/win/BUILD.gn

Issue 2087723003: Use the /PROFILE linker flag for the Windows GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/win/BUILD.gn
diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn
index e8039c0b1f75eb628f2c419bbe2aebf8de9f32d6..9188a081eb350894c7c63aaf7281ade93b07138b 100644
--- a/build/config/win/BUILD.gn
+++ b/build/config/win/BUILD.gn
@@ -96,9 +96,11 @@ config("compiler") {
lib_dirs = [ "//third_party/llvm-build/Release+Asserts/lib/clang/$clang_version/lib/windows" ]
}
- if (is_syzyasan) {
- # SyzyAsan needs /PROFILE turned on to produce appropriate pdbs.
- assert(!is_win_fastlink, "/PROFILE and /DEBUG:FASTLINK are incompatible")
+ # Ensures that the PDB file contains FIXUP information (growing the PDB file
+ # by about 5%) but does not otherwise alter the output binary. This
+ # information is used by the Syzygy optimization tool when decomposing the
+ # release image.
+ if (!is_debug && !is_win_fastlink && !is_clang) {
brucedawson 2016/06/21 21:28:49 I didn't notice is_clang checks in the GYP version
Sébastien Marchand 2016/06/22 14:59:47 There's no 'is_clang' check in the GYP version of
ldflags = [ "/PROFILE" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698