Use the /PROFILE linker flag for the Windows GN builds.

build/config/win/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/compiler/compiler.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/win/visual_studio_version.gni")
 import("//build/toolchain/toolchain.gni")
 
 assert(is_win)
@@ skipping 78 matching lines @@
         # cmd.exe doesn't understand ANSI escape codes by default,
         # so only enable them if something emulating them is around.
         "-fansi-escape-codes",
       ]
     }
 
     # Clang runtime libraries, such as the sanitizer runtimes, live here.
     lib_dirs = [ "//third_party/llvm-build/Release+Asserts/lib/clang/$clang_version/lib/windows" ]
   }
 
-  if (is_syzyasan) {
-    # SyzyAsan needs /PROFILE turned on to produce appropriate pdbs.
-    assert(!is_win_fastlink, "/PROFILE and /DEBUG:FASTLINK are incompatible")
+  # Ensures that the PDB file contains FIXUP information (growing the PDB file
+  # by about 5%) but does not otherwise alter the output binary. This
+  # information is used by the Syzygy optimization tool when decomposing the
+  # release image.
+  if (!is_debug && !is_win_fastlink && !is_clang) {

[brucedawson, 2016/06/21 21:28:49]

I didn't notice is_clang checks in the GYP version of this setting, although the
PROFILE settings were pretty well spread out so I can't be sure. Is the is_clang
check appropriate?

Also, do we want /PROFILE on non-syzyasan builds?

Also, there has been some discussion of turning on incremental linking for
release component builds, and incremental linking is incompatible with /PROFILE.

Just checking to make sure we have the right cases. It sounds like generating
the FIXUP information is not free so we might as well do it as rarely as
possible. I only noticed build breaks from the lack of this on official builds,
FWIW.

[Sébastien Marchand, 2016/06/22 14:59:47]

There's no 'is_clang' check in the GYP version of this setting but this is
probably a mistake as we don't plan to support the Clang builds (what we're
doing with Syzygy doesn't really make sense with Clang).

We should keep in mind that we'll need to add an additional check the day we'll
turn on incremental linking for the release component builds (there's not so
much we can do until then). 

Generating the FIXUP information only affect the PDB (for a 5% increase in
size), and I think that keeping the ability to instrument (with SyzyAsan or for
Coverage) 'any' Chrome build without rebuilding is worth this extra cost ? 

     ldflags = [ "/PROFILE" ]
   }
 
   # arflags apply only to static_libraries. The normal linker configs are only
   # set for executable and shared library targets so arflags must be set
   # elsewhere. Since this is relatively contained, we just apply them in this
   # more general config and they will only have an effect on static libraries.
   arflags = [
     # "No public symbols found; archive member will be inaccessible." This
     # means that one or more object files in the library can never be
@@ skipping 274 matching lines @@
 
 # Internal stuff --------------------------------------------------------------
 
 # Config used by the MIDL template to disable warnings.
 config("midl_warnings") {
   if (is_clang) {
     # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".
     cflags = [ "-Wno-extra-tokens" ]
   }
 }