Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2087673002: Remove CreateGpuMemoryBufferFromClientId and plumbing (Closed)

Created:
4 years, 6 months ago by ccameron
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, anandc+watch-blimp_chromium.org, ben+mojo_chromium.org, cc-bugs_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, erikchen, feature-media-reviews_chromium.org, jam, jessicag+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, miu+watch_chromium.org, nyquist+watch-blimp_chromium.org, piman+watch_chromium.org, piman, posciak+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, shaktisahu+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CreateGpuMemoryBufferFromClientId and plumbing This interface is for an approach that will not be used. This in effect reverts r396084, r395454, r395040, and r394958. BUG=608026 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/399d94a026f104afe16d129cb587431351b0419d Cr-Commit-Position: refs/heads/master@{#401186}

Patch Set 1 #

Patch Set 2 : More trimming #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -309 lines) Patch
M blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M cc/blink/web_external_texture_layer_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/ipc/cc_param_traits_macros.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/ipc/struct_traits_unittest.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download
M cc/ipc/transferable_resource.mojom View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/ipc/transferable_resource_struct_traits.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M cc/layers/texture_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/resources/resource_provider.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/resource_provider.cc View 1 2 5 chunks +0 lines, -7 lines 0 comments Download
M cc/resources/texture_mailbox.h View 1 4 chunks +0 lines, -6 lines 0 comments Download
M cc/resources/texture_mailbox.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/transferable_resource.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M cc/test/test_gpu_memory_buffer_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/test/test_gpu_memory_buffer_manager.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M components/exo/buffer.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M components/mus/common/mojo_gpu_memory_buffer_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/mus/common/mojo_gpu_memory_buffer_manager.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M components/mus/gpu/mus_gpu_memory_buffer_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/mus/gpu/mus_gpu_memory_buffer_manager.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M components/mus/surfaces/ozone_gpu_memory_buffer_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/mus/surfaces/ozone_gpu_memory_buffer_manager.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.h View 1 5 chunks +1 line, -16 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 9 chunks +2 lines, -101 lines 0 comments Download
M content/child/child_gpu_memory_buffer_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/child_gpu_memory_buffer_manager.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/gpu_memory_buffer_manager.h View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/ipc/client/gpu_memory_buffer_impl_io_surface.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M media/base/video_frame.h View 3 chunks +0 lines, -19 lines 0 comments Download
M media/base/video_frame.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 33 (18 generated)
ccameron
This is just a large revert. This removes everything except - WebKit changes using this ...
4 years, 6 months ago (2016-06-21 00:46:04 UTC) #9
piman
lgtm
4 years, 6 months ago (2016-06-21 00:56:05 UTC) #10
dcheng
lgtm
4 years, 6 months ago (2016-06-21 02:14:46 UTC) #11
ccameron
Adding blundell@ for components/ Adding sandersd@ for media/ Adding kmarshall@ for blimp/
4 years, 6 months ago (2016-06-21 05:08:47 UTC) #13
blundell
-blundell +sky for //components/mus +reveman for //components/exo Prefer owners of individual components in //components, thanks.
4 years, 6 months ago (2016-06-21 07:31:10 UTC) #15
reveman
components/exo lgtm
4 years, 6 months ago (2016-06-21 09:16:14 UTC) #17
sky
mus LGTM
4 years, 6 months ago (2016-06-21 16:15:13 UTC) #18
sandersd (OOO until July 31)
media/ lgtm
4 years, 6 months ago (2016-06-21 17:45:15 UTC) #19
ccameron
Adding wez@ for blimp/ OWNER
4 years, 6 months ago (2016-06-21 19:08:32 UTC) #21
Wez
blimp/ LGTM
4 years, 6 months ago (2016-06-21 22:18:59 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087673002/80001
4 years, 6 months ago (2016-06-21 22:24:41 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/87394) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 6 months ago (2016-06-21 22:30:44 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087673002/100001
4 years, 6 months ago (2016-06-21 23:50:08 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 6 months ago (2016-06-22 03:09:25 UTC) #31
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 03:11:12 UTC) #33
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/399d94a026f104afe16d129cb587431351b0419d
Cr-Commit-Position: refs/heads/master@{#401186}

Powered by Google App Engine
This is Rietveld 408576698