Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Side by Side Diff: content/browser/gpu/browser_gpu_memory_buffer_manager.h

Issue 2087673002: Remove CreateGpuMemoryBufferFromClientId and plumbing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_GPU_BROWSER_GPU_MEMORY_BUFFER_MANAGER_H_ 5 #ifndef CONTENT_BROWSER_GPU_BROWSER_GPU_MEMORY_BUFFER_MANAGER_H_
6 #define CONTENT_BROWSER_GPU_BROWSER_GPU_MEMORY_BUFFER_MANAGER_H_ 6 #define CONTENT_BROWSER_GPU_BROWSER_GPU_MEMORY_BUFFER_MANAGER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 11 matching lines...) Expand all
22 22
23 namespace content { 23 namespace content {
24 24
25 using GpuMemoryBufferConfigurationKey = 25 using GpuMemoryBufferConfigurationKey =
26 std::pair<gfx::BufferFormat, gfx::BufferUsage>; 26 std::pair<gfx::BufferFormat, gfx::BufferUsage>;
27 using GpuMemoryBufferConfigurationSet = 27 using GpuMemoryBufferConfigurationSet =
28 base::hash_set<GpuMemoryBufferConfigurationKey>; 28 base::hash_set<GpuMemoryBufferConfigurationKey>;
29 29
30 } // content 30 } // content
31 31
32 namespace gpu {
33 class GpuMemoryBufferImpl;
34 } // gpu
35
36 namespace BASE_HASH_NAMESPACE { 32 namespace BASE_HASH_NAMESPACE {
37 33
38 template <> 34 template <>
39 struct hash<content::GpuMemoryBufferConfigurationKey> { 35 struct hash<content::GpuMemoryBufferConfigurationKey> {
40 size_t operator()(const content::GpuMemoryBufferConfigurationKey& key) const { 36 size_t operator()(const content::GpuMemoryBufferConfigurationKey& key) const {
41 return base::HashInts(static_cast<int>(key.first), 37 return base::HashInts(static_cast<int>(key.first),
42 static_cast<int>(key.second)); 38 static_cast<int>(key.second));
43 } 39 }
44 }; 40 };
45 41
(...skipping 24 matching lines...) Expand all
70 // Overridden from gpu::GpuMemoryBufferManager: 66 // Overridden from gpu::GpuMemoryBufferManager:
71 std::unique_ptr<gfx::GpuMemoryBuffer> AllocateGpuMemoryBuffer( 67 std::unique_ptr<gfx::GpuMemoryBuffer> AllocateGpuMemoryBuffer(
72 const gfx::Size& size, 68 const gfx::Size& size,
73 gfx::BufferFormat format, 69 gfx::BufferFormat format,
74 gfx::BufferUsage usage, 70 gfx::BufferUsage usage,
75 gpu::SurfaceHandle surface_handle) override; 71 gpu::SurfaceHandle surface_handle) override;
76 std::unique_ptr<gfx::GpuMemoryBuffer> CreateGpuMemoryBufferFromHandle( 72 std::unique_ptr<gfx::GpuMemoryBuffer> CreateGpuMemoryBufferFromHandle(
77 const gfx::GpuMemoryBufferHandle& handle, 73 const gfx::GpuMemoryBufferHandle& handle,
78 const gfx::Size& size, 74 const gfx::Size& size,
79 gfx::BufferFormat format) override; 75 gfx::BufferFormat format) override;
80 std::unique_ptr<gfx::GpuMemoryBuffer> CreateGpuMemoryBufferFromClientId(
81 int client_id,
82 const gfx::GpuMemoryBufferId& gpu_memory_buffer_id) override;
83 gfx::GpuMemoryBuffer* GpuMemoryBufferFromClientBuffer( 76 gfx::GpuMemoryBuffer* GpuMemoryBufferFromClientBuffer(
84 ClientBuffer buffer) override; 77 ClientBuffer buffer) override;
85 void SetDestructionSyncToken(gfx::GpuMemoryBuffer* buffer, 78 void SetDestructionSyncToken(gfx::GpuMemoryBuffer* buffer,
86 const gpu::SyncToken& sync_token) override; 79 const gpu::SyncToken& sync_token) override;
87 80
88 // Overridden from base::trace_event::MemoryDumpProvider: 81 // Overridden from base::trace_event::MemoryDumpProvider:
89 bool OnMemoryDump(const base::trace_event::MemoryDumpArgs& args, 82 bool OnMemoryDump(const base::trace_event::MemoryDumpArgs& args,
90 base::trace_event::ProcessMemoryDump* pmd) override; 83 base::trace_event::ProcessMemoryDump* pmd) override;
91 84
92 void AllocateGpuMemoryBufferForChildProcess( 85 void AllocateGpuMemoryBufferForChildProcess(
(...skipping 15 matching lines...) Expand all
108 gfx::BufferUsage usage) const; 101 gfx::BufferUsage usage) const;
109 102
110 private: 103 private:
111 struct BufferInfo { 104 struct BufferInfo {
112 BufferInfo(); 105 BufferInfo();
113 BufferInfo(const gfx::Size& size, 106 BufferInfo(const gfx::Size& size,
114 gfx::GpuMemoryBufferType type, 107 gfx::GpuMemoryBufferType type,
115 gfx::BufferFormat format, 108 gfx::BufferFormat format,
116 gfx::BufferUsage usage, 109 gfx::BufferUsage usage,
117 int gpu_host_id); 110 int gpu_host_id);
118 BufferInfo(BufferInfo&& other); 111 BufferInfo(const BufferInfo& other);
119 ~BufferInfo(); 112 ~BufferInfo();
120 113
121 gfx::Size size; 114 gfx::Size size;
122 gfx::GpuMemoryBufferType type = gfx::EMPTY_BUFFER; 115 gfx::GpuMemoryBufferType type = gfx::EMPTY_BUFFER;
123 gfx::BufferFormat format = gfx::BufferFormat::RGBA_8888; 116 gfx::BufferFormat format = gfx::BufferFormat::RGBA_8888;
124 gfx::BufferUsage usage = gfx::BufferUsage::GPU_READ; 117 gfx::BufferUsage usage = gfx::BufferUsage::GPU_READ;
125 int gpu_host_id = 0; 118 int gpu_host_id = 0;
126
127 // An open instance of the buffer in the browser process.
128 // TODO(ccameron): This only is implemented for IOSurface buffers. Ensure
129 // that this is always valid, and delete the then-redundant above state.
130 std::unique_ptr<gpu::GpuMemoryBufferImpl> buffer;
131 }; 119 };
132 120
133 struct CreateGpuMemoryBufferRequest; 121 struct CreateGpuMemoryBufferRequest;
134 struct CreateGpuMemoryBufferFromHandleRequest; 122 struct CreateGpuMemoryBufferFromHandleRequest;
135 struct CreateGpuMemoryBufferFromClientIdRequest;
136 123
137 using CreateDelegate = base::Callback<void(GpuProcessHost* host, 124 using CreateDelegate = base::Callback<void(GpuProcessHost* host,
138 gfx::GpuMemoryBufferId id, 125 gfx::GpuMemoryBufferId id,
139 const gfx::Size& size, 126 const gfx::Size& size,
140 gfx::BufferFormat format, 127 gfx::BufferFormat format,
141 gfx::BufferUsage usage, 128 gfx::BufferUsage usage,
142 int client_id, 129 int client_id,
143 const CreateCallback& callback)>; 130 const CreateCallback& callback)>;
144 131
145 std::unique_ptr<gfx::GpuMemoryBuffer> AllocateGpuMemoryBufferForSurface( 132 std::unique_ptr<gfx::GpuMemoryBuffer> AllocateGpuMemoryBufferForSurface(
146 const gfx::Size& size, 133 const gfx::Size& size,
147 gfx::BufferFormat format, 134 gfx::BufferFormat format,
148 gfx::BufferUsage usage, 135 gfx::BufferUsage usage,
149 gpu::SurfaceHandle surface_handle); 136 gpu::SurfaceHandle surface_handle);
150 137
151 // Functions that handle synchronous buffer creation requests. 138 // Functions that handle synchronous buffer creation requests.
152 void HandleCreateGpuMemoryBufferOnIO(CreateGpuMemoryBufferRequest* request); 139 void HandleCreateGpuMemoryBufferOnIO(CreateGpuMemoryBufferRequest* request);
153 void HandleCreateGpuMemoryBufferFromHandleOnIO( 140 void HandleCreateGpuMemoryBufferFromHandleOnIO(
154 CreateGpuMemoryBufferFromHandleRequest* request); 141 CreateGpuMemoryBufferFromHandleRequest* request);
155 void HandleCreateGpuMemoryBufferFromClientIdOnIO(
156 CreateGpuMemoryBufferFromClientIdRequest* request);
157 void HandleGpuMemoryBufferCreatedOnIO( 142 void HandleGpuMemoryBufferCreatedOnIO(
158 CreateGpuMemoryBufferRequest* request, 143 CreateGpuMemoryBufferRequest* request,
159 const gfx::GpuMemoryBufferHandle& handle); 144 const gfx::GpuMemoryBufferHandle& handle);
160 145
161 // Functions that implement asynchronous buffer creation. 146 // Functions that implement asynchronous buffer creation.
162 void CreateGpuMemoryBufferOnIO(const CreateDelegate& create_delegate, 147 void CreateGpuMemoryBufferOnIO(const CreateDelegate& create_delegate,
163 gfx::GpuMemoryBufferId id, 148 gfx::GpuMemoryBufferId id,
164 const gfx::Size& size, 149 const gfx::Size& size,
165 gfx::BufferFormat format, 150 gfx::BufferFormat format,
166 gfx::BufferUsage usage, 151 gfx::BufferUsage usage,
(...skipping 25 matching lines...) Expand all
192 using BufferMap = base::hash_map<gfx::GpuMemoryBufferId, BufferInfo>; 177 using BufferMap = base::hash_map<gfx::GpuMemoryBufferId, BufferInfo>;
193 using ClientMap = base::hash_map<int, BufferMap>; 178 using ClientMap = base::hash_map<int, BufferMap>;
194 ClientMap clients_; 179 ClientMap clients_;
195 180
196 DISALLOW_COPY_AND_ASSIGN(BrowserGpuMemoryBufferManager); 181 DISALLOW_COPY_AND_ASSIGN(BrowserGpuMemoryBufferManager);
197 }; 182 };
198 183
199 } // namespace content 184 } // namespace content
200 185
201 #endif // CONTENT_BROWSER_GPU_BROWSER_GPU_MEMORY_BUFFER_MANAGER_H_ 186 #endif // CONTENT_BROWSER_GPU_BROWSER_GPU_MEMORY_BUFFER_MANAGER_H_
OLDNEW
« no previous file with comments | « components/mus/surfaces/ozone_gpu_memory_buffer_manager.cc ('k') | content/browser/gpu/browser_gpu_memory_buffer_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698