components/web_modal/web_contents_modal_dialog_manager_unittest.cc - Issue 2087643003: Move web modal dialog manager files into the constrained_window component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_modal/web_contents_modal_dialog_manager_unittest.cc

Issue 2087643003: Move web modal dialog manager files into the constrained_window component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert NativeManagerTracker split, delete CreateNativeWebModalManager impls w/ two left for Cocoa a… Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/web_modal/web_contents_modal_dialog_manager.h ('K') | « components/web_modal/web_contents_modal_dialog_manager.cc ('k') | extensions/extensions_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_modal/web_contents_modal_dialog_manager_unittest.cc

diff --git a/components/web_modal/web_contents_modal_dialog_manager_unittest.cc b/components/web_modal/web_contents_modal_dialog_manager_unittest.cc

index 75c749eb1c8c15acff9e6b3e9f9ed919724a04d2..43fc22ec55f03db9ac4e752d323df0b4932c8d56 100644

--- a/components/web_modal/web_contents_modal_dialog_manager_unittest.cc

+++ b/components/web_modal/web_contents_modal_dialog_manager_unittest.cc

@@ -123,17 +123,6 @@ class WebContentsModalDialogManagerTest

DISALLOW_COPY_AND_ASSIGN(WebContentsModalDialogManagerTest);

};

-SingleWebContentsDialogManager*

-WebContentsModalDialogManager::CreateNativeWebModalManager(

- gfx::NativeWindow dialog,

- SingleWebContentsDialogManagerDelegate* native_delegate) {

- NOTREACHED();

- return new TestNativeWebContentsModalDialogManager(

- dialog,

- native_delegate,

- &unused_tracker);

// Test that the dialog is shown immediately when the delegate indicates the web

// contents is visible.

TEST_F(WebContentsModalDialogManagerTest, WebContentsVisible) {