components/constrained_window/web_contents_modal_dialog_manager_views.cc - Issue 2087643003: Move web modal dialog manager files into the constrained_window component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/constrained_window/web_contents_modal_dialog_manager_views.cc

Issue 2087643003: Move web modal dialog manager files into the constrained_window component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase? Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/constrained_window/native_web_contents_modal_dialog_manager_views.h ('K') | « components/constrained_window/native_web_contents_modal_dialog_manager_views.cc ('k') | components/web_modal.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/constrained_window/web_contents_modal_dialog_manager_views.cc

diff --git a/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc b/components/constrained_window/web_contents_modal_dialog_manager_views.cc

similarity index 73%

copy from chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc

copy to components/constrained_window/web_contents_modal_dialog_manager_views.cc

index 94ab725c0da13402fa1c06240990bf47710b3704..1d1b6d3999986cecd2ecea0709fbeef0af261437 100644

--- a/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc

+++ b/components/constrained_window/web_contents_modal_dialog_manager_views.cc

@@ -4,7 +4,7 @@

#include "components/web_modal/web_contents_modal_dialog_manager.h"

-#include "chrome/browser/ui/views/native_web_contents_modal_dialog_manager_views.h"

+#include "components/constrained_window/native_web_contents_modal_dialog_manager_views.h"

#include "components/web_modal/single_web_contents_dialog_manager.h"

namespace web_modal {

@@ -13,7 +13,8 @@ SingleWebContentsDialogManager*

WebContentsModalDialogManager::CreateNativeWebModalManager(

gfx::NativeWindow dialog,

SingleWebContentsDialogManagerDelegate* native_delegate) {

- return new NativeWebContentsModalDialogManagerViews(dialog, native_delegate);

+ return new constrained_window::NativeWebContentsModalDialogManagerViews(

+ dialog, native_delegate);

}

} // namespace web_modal