Move web modal dialog manager files into the constrained_window component.

components/constrained_window/web_contents_modal_dialog_manager_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/web_modal/web_contents_modal_dialog_manager.h"
 
-#include "chrome/browser/ui/views/native_web_contents_modal_dialog_manager_views.h"
+#include "components/constrained_window/native_web_contents_modal_dialog_manager_views.h"
 #include "components/web_modal/single_web_contents_dialog_manager.h"
 
 namespace web_modal {
 
 SingleWebContentsDialogManager*

[tapted, 2016/06/29 03:02:45]

Add

/ /TODO(..) This is a layering violation and should be deleted. Currently it's
needed by WebContentsModalDialogManager::ShowModalDialog() which is still used
by X and Y, but they
should use constrained_window::ShowModalDialog instead.

(or if it's easy, just make it TODONE in this CL, delete this file, and hide
WebContentsModalDialogManager::ShowModalDialog() with #ifdef MAC

[Patti Lor, 2016/07/13 03:09:41]

I think I already removed WebContentsModalDialogManager::ShowModalDialog() - or
not removed, moved it to constrained_window::ShowModalDialog() instead. See
https://codereview.chromium.org/2087643003/diff/180001/components/web_modal/w....
Is that what you meant?

[tapted, 2016/07/13 04:36:19]

There's still a problem - even though this has been moved from
chrome/browser/ui/views to components/contrained_window, it's still defining a
symbol in the 'web_modal' namespace, which is backward.

That is, web_modal should be at the "bottom" of the layer cake. So it should be
able to be linked into an .so or .dll library in isolation, without needing to
link against constrained_window or chrome.dll to provide missing symbols
("backreferences"). We actually don't allow backreferences (dlls don't support
them), so the only way it works now is by having web_modal declare itself as a
static_library (".a" rather than .so or .dll)

So we should still have the comment, but this file isn't compiled for Cocoa
builds -- if that's the only reason we need it we might be able to delete it
instead, but this may depend on the other comment.

[Patti Lor, 2016/07/19 07:39:08]

This file was deleted, but I think ShowModalDialog() is needed for other
platforms as well, not sure if that part of your first comment still applies.

 WebContentsModalDialogManager::CreateNativeWebModalManager(
     gfx::NativeWindow dialog,
     SingleWebContentsDialogManagerDelegate* native_delegate) {
-  return new NativeWebContentsModalDialogManagerViews(dialog, native_delegate);
+  return new constrained_window::NativeWebContentsModalDialogManagerViews(
+      dialog, native_delegate);
 }
 
 }  // namespace web_modal