Defines TriggerConditions and plumbs up to BackgroundScheduler

components/offline_pages/background/request_coordinator_unittest.cc

Index: components/offline_pages/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_unittest.cc b/components/offline_pages/background/request_coordinator_unittest.cc
index ebcbe140f39a7b3f1a30b8ffbf8e619d52ed20f4..ae9c1b0e92ea777297b47cdfe6a7999e8a002a9c 100644
--- a/components/offline_pages/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_unittest.cc
@@ -33,10 +33,14 @@ const int kRequestId(1);
 
 class SchedulerStub : public Scheduler {
  public:
-  SchedulerStub() : schedule_called_(false), unschedule_called_(false) {}
+  SchedulerStub()
+      : schedule_called_(false),
+        unschedule_called_(false),
+        conditions_(false, 0, false) {}
 
-  void Schedule(const TriggerCondition& trigger_condition) override {
+  void Schedule(const TriggerConditions& trigger_conditions) override {
     schedule_called_ = true;
+    conditions_ = trigger_conditions;
   }
 
   // Unschedules the currently scheduled task, if any.
@@ -48,9 +52,12 @@ class SchedulerStub : public Scheduler {
 
   bool unschedule_called() const { return unschedule_called_; }
 
+  TriggerConditions const* conditions() const { return &conditions_; }
+
  private:
   bool schedule_called_;
   bool unschedule_called_;
+  TriggerConditions conditions_;
 };
 
 class OfflinerStub : public Offliner {
@@ -195,6 +202,7 @@ TEST_F(RequestCoordinatorTest, SavePageLater) {
   SchedulerStub* scheduler_stub = reinterpret_cast<SchedulerStub*>(
       coordinator()->scheduler());
   EXPECT_TRUE(scheduler_stub->schedule_called());
+  EXPECT_EQ(50, scheduler_stub->conditions()->minimum_battery_percentage);

[Pete Williamson, 2016/06/20 23:14:03]

Where did this 50 come from?  I didn't see a corresponding change in the test to
set the battery percentage to 50.

[dougarnett, 2016/06/22 19:54:18]

This value is from the single constant kUserRequestTriggerConditions added to
coordinator class (line 22). I could expose that constant and check here - I was
hesitant to do that because I expect we might want to not have that constant
there and instead have the Policy object providing the TriggerConditions. 

[Pete Williamson, 2016/06/22 20:49:11]

How about we make the constant a public constant in RequestCoordinator, and use
that for now.

Eventually, when this moves into policy, we can put the number we want into the
policy object we use at test set up time.

[dougarnett, 2016/06/22 21:52:16]

added public method with TODO

 }
 
 TEST_F(RequestCoordinatorTest, OfflinerDoneRequestSucceeded) {