Defines TriggerConditions and plumbs up to BackgroundScheduler

chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java

Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
index 1c2da05ed6e419d4dedfdbc9dbc047bbccea0a4a..23629ea0bf9f90446de03bb82f09c8ae9960cbef 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java
@@ -43,7 +43,7 @@ public class BackgroundSchedulerTest {
     public void testSchedule() {
         BackgroundScheduler scheduler = new BackgroundScheduler();
         assertNull(ShadowGcmNetworkManager.getScheduledTask());
-        scheduler.schedule(mContext);
+        scheduler.schedule(mContext, new TriggerConditions(true, 10, false));

[fgorski, 2016/06/20 22:46:54]

nit: this will quickly get unreadable.
Is there a way to explain the boolean values?

This applies to same problem on c++ side.

[Pete Williamson, 2016/06/20 23:14:03]

To make things a little bit better, we could create the test trigger conditions
once in the setUp method, and document them there.

We can create boolean constants REQUIRE_WALL_POWER (true), NO_WALL_POWER_NEEDED
(false) and use them at the point of creating a TriggerConditions object.

Another potential approach is to use enums instead of boolean values, but I
prefer using boolean values here since we have to send them over JNI.

[dougarnett, 2016/06/22 19:54:18]

Commented ctor parms and consolidated into single member var for both tests.
 

         // Check with gcmNetworkManagerShadow that schedule got called.
         assertNotNull(ShadowGcmNetworkManager.getScheduledTask());
 
@@ -59,7 +59,7 @@ public class BackgroundSchedulerTest {
     public void testUnschedule() {
         BackgroundScheduler scheduler = new BackgroundScheduler();
         assertNull(ShadowGcmNetworkManager.getScheduledTask());
-        scheduler.schedule(mContext);
+        scheduler.schedule(mContext, new TriggerConditions(true, 10, false));
         assertNotNull(ShadowGcmNetworkManager.getScheduledTask());
 
         assertNull(ShadowGcmNetworkManager.getCanceledTask());