Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issue 2087583002: Remove calls to MessageLoop::current() in components. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews, rjkroege, estade+watch_chromium.org, rouslan+autofill_chromium.org, jdonnelly+autofillwatch_chromium.org, pfeldman, asvitkine+watch_chromium.org, devtools-reviews_chromium.org, vabr+watchlistautofill_chromium.org, piman+watch_chromium.org, scheduler-bugs_chromium.org, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::current() in components. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. BUG=616447 R=caitkp@chromium.org Committed: https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6 Cr-Commit-Position: refs/heads/master@{#401716}

Patch Set 1 #

Patch Set 2 : fix build errors #

Patch Set 3 : fix test error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -97 lines) Patch
M components/devtools_http_handler/devtools_http_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/impl/sync_invalidation_listener_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/invalidation/impl/sync_system_resources.h View 3 chunks +5 lines, -5 lines 0 comments Download
M components/invalidation/impl/sync_system_resources.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M components/mus/common/gpu_service.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/mus/common/gpu_service.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M components/mus/gpu/gpu_service_mus.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/gpu/gpu_service_mus.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/loader/nacl_listener.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_listener.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M components/policy/core/browser/browser_policy_connector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_driver/glue/sync_backend_host_core.cc View 24 chunks +31 lines, -31 lines 0 comments Download
M components/sync_driver/glue/sync_backend_host_impl.h View 2 chunks +5 lines, -3 lines 0 comments Download
M components/sync_driver/glue/sync_backend_host_impl.cc View 1 17 chunks +18 lines, -18 lines 0 comments Download
M components/variations/variations_http_header_provider.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/webdata/common/web_data_request_manager.h View 4 chunks +5 lines, -8 lines 0 comments Download
M components/webdata/common/web_data_request_manager.cc View 1 2 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Cait (Slow)
lgtm
4 years, 6 months ago (2016-06-20 21:20:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087583002/20001
4 years, 6 months ago (2016-06-23 17:01:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/234420)
4 years, 6 months ago (2016-06-23 18:38:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087583002/40001
4 years, 6 months ago (2016-06-23 20:21:01 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-23 21:20:50 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 21:24:05 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cddcf0efb1c2f1050c9e90a6cb849d25576e74f6
Cr-Commit-Position: refs/heads/master@{#401716}

Powered by Google App Engine
This is Rietveld 408576698