Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: components/variations/variations_http_header_provider.cc

Issue 2087583002: Remove calls to MessageLoop::current() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test error Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/variations/variations_http_header_provider.h" 5 #include "components/variations/variations_http_header_provider.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/base64.h" 13 #include "base/base64.h"
14 #include "base/memory/singleton.h" 14 #include "base/memory/singleton.h"
15 #include "base/metrics/histogram_macros.h" 15 #include "base/metrics/histogram_macros.h"
16 #include "base/strings/string_number_conversions.h" 16 #include "base/strings/string_number_conversions.h"
17 #include "base/strings/string_split.h" 17 #include "base/strings/string_split.h"
18 #include "base/strings/string_util.h" 18 #include "base/strings/string_util.h"
19 #include "base/threading/thread_task_runner_handle.h"
19 #include "components/variations/proto/client_variations.pb.h" 20 #include "components/variations/proto/client_variations.pb.h"
20 21
21 namespace variations { 22 namespace variations {
22 23
23 // static 24 // static
24 VariationsHttpHeaderProvider* VariationsHttpHeaderProvider::GetInstance() { 25 VariationsHttpHeaderProvider* VariationsHttpHeaderProvider::GetInstance() {
25 return base::Singleton<VariationsHttpHeaderProvider>::get(); 26 return base::Singleton<VariationsHttpHeaderProvider>::get();
26 } 27 }
27 28
28 std::string VariationsHttpHeaderProvider::GetClientDataHeader() { 29 std::string VariationsHttpHeaderProvider::GetClientDataHeader() {
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 UpdateVariationIDsHeaderValue(); 133 UpdateVariationIDsHeaderValue();
133 } 134 }
134 135
135 void VariationsHttpHeaderProvider::InitVariationIDsCacheIfNeeded() { 136 void VariationsHttpHeaderProvider::InitVariationIDsCacheIfNeeded() {
136 base::AutoLock scoped_lock(lock_); 137 base::AutoLock scoped_lock(lock_);
137 if (variation_ids_cache_initialized_) 138 if (variation_ids_cache_initialized_)
138 return; 139 return;
139 140
140 // Register for additional cache updates. This is done first to avoid a race 141 // Register for additional cache updates. This is done first to avoid a race
141 // that could cause registered FieldTrials to be missed. 142 // that could cause registered FieldTrials to be missed.
142 DCHECK(base::MessageLoop::current()); 143 DCHECK(base::ThreadTaskRunnerHandle::IsSet());
143 base::FieldTrialList::AddObserver(this); 144 base::FieldTrialList::AddObserver(this);
144 145
145 base::TimeTicks before_time = base::TimeTicks::Now(); 146 base::TimeTicks before_time = base::TimeTicks::Now();
146 147
147 base::FieldTrial::ActiveGroups initial_groups; 148 base::FieldTrial::ActiveGroups initial_groups;
148 base::FieldTrialList::GetActiveFieldTrialGroups(&initial_groups); 149 base::FieldTrialList::GetActiveFieldTrialGroups(&initial_groups);
149 150
150 for (const auto& entry : initial_groups) { 151 for (const auto& entry : initial_groups) {
151 const VariationID id = 152 const VariationID id =
152 GetGoogleVariationID(GOOGLE_WEB_PROPERTIES, entry.trial_name, 153 GetGoogleVariationID(GOOGLE_WEB_PROPERTIES, entry.trial_name,
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 224
224 std::set<VariationID> all_variation_ids_set = default_variation_ids_set_; 225 std::set<VariationID> all_variation_ids_set = default_variation_ids_set_;
225 for (VariationID id : variation_ids_set_) 226 for (VariationID id : variation_ids_set_)
226 all_variation_ids_set.insert(id); 227 all_variation_ids_set.insert(id);
227 for (VariationID id : synthetic_variation_ids_set_) 228 for (VariationID id : synthetic_variation_ids_set_)
228 all_variation_ids_set.insert(id); 229 all_variation_ids_set.insert(id);
229 return all_variation_ids_set; 230 return all_variation_ids_set;
230 } 231 }
231 232
232 } // namespace variations 233 } // namespace variations
OLDNEW
« no previous file with comments | « components/sync_driver/glue/sync_backend_host_impl.cc ('k') | components/webdata/common/web_data_request_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698