Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2087463004: Revert of [heap] Avoid the use of cells to point from code to new-space objects. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
Reviewers:
titzer, ulan, ahaas
CC:
Hannes Payer (out of office), Michael Achenbach, Michael Starzinger, titzer, ulan, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Avoid the use of cells to point from code to new-space objects. (patchset #7 id:120001 of https://codereview.chromium.org/2045263002/ ) Reason for revert: [Sheriff] Breaks arm debug: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/builds/1038 Original issue's description: > [heap] Avoid the use of cells to point from code to new-space objects. > > Cells were needed originally because there was no typed remembered set to > record direct pointers from code space to new space. A previous > CL (https://codereview.chromium.org/2003553002/) already introduced > the remembered set, this CL uses it. > > This CL > * stores direct pointers in code objects, even if the target is in new space, > * records the slot of the pointer in typed-old-to-new remembered set, > * adds a list which stores weak code-to-new-space references, > * adds a test to test-heap.cc for weak code-to-new-space references, > * removes prints in tail-call-megatest.js > > R=ulan@chromium.org > > Committed: https://crrev.com/2d2087b79a293a92a6ed34a2775e481ff2173b3c > Cr-Commit-Position: refs/heads/master@{#37134} TBR=titzer@chromium.org,ulan@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1f12208101e3eee147abe01e063eb9243a9689c6 Cr-Commit-Position: refs/heads/master@{#37139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -272 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M src/heap/heap.h View 3 chunks +0 lines, -10 lines 0 comments Download
M src/heap/heap.cc View 7 chunks +37 lines, -37 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/mark-compact.cc View 9 chunks +20 lines, -50 lines 0 comments Download
M src/heap/remembered-set.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/heap/remembered-set.cc View 2 chunks +10 lines, -33 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +27 lines, -5 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +5 lines, -19 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/x87/assembler-x87-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +9 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [heap] Avoid the use of cells to point from code to new-space ...
4 years, 6 months ago (2016-06-21 12:09:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087463004/1
4 years, 6 months ago (2016-06-21 12:09:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 12:09:42 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 12:10:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f12208101e3eee147abe01e063eb9243a9689c6
Cr-Commit-Position: refs/heads/master@{#37139}

Powered by Google App Engine
This is Rietveld 408576698