Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: src/x87/assembler-x87-inl.h

Issue 2087463004: Revert of [heap] Avoid the use of cells to point from code to new-space objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | test/cctest/heap/test-heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); 133 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
134 Memory::Object_at(pc_) = target; 134 Memory::Object_at(pc_) = target;
135 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 135 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
136 Assembler::FlushICache(isolate_, pc_, sizeof(Address)); 136 Assembler::FlushICache(isolate_, pc_, sizeof(Address));
137 } 137 }
138 if (write_barrier_mode == UPDATE_WRITE_BARRIER && 138 if (write_barrier_mode == UPDATE_WRITE_BARRIER &&
139 host() != NULL && 139 host() != NULL &&
140 target->IsHeapObject()) { 140 target->IsHeapObject()) {
141 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode( 141 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(
142 host(), this, HeapObject::cast(target)); 142 host(), this, HeapObject::cast(target));
143 host()->GetHeap()->RecordWriteIntoCode(host(), this, target);
144 } 143 }
145 } 144 }
146 145
147 146
148 Address RelocInfo::target_external_reference() { 147 Address RelocInfo::target_external_reference() {
149 DCHECK(rmode_ == RelocInfo::EXTERNAL_REFERENCE); 148 DCHECK(rmode_ == RelocInfo::EXTERNAL_REFERENCE);
150 return Memory::Address_at(pc_); 149 return Memory::Address_at(pc_);
151 } 150 }
152 151
153 152
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
549 548
550 Operand::Operand(Immediate imm) { 549 Operand::Operand(Immediate imm) {
551 // [disp/r] 550 // [disp/r]
552 set_modrm(0, ebp); 551 set_modrm(0, ebp);
553 set_dispr(imm.x_, imm.rmode_); 552 set_dispr(imm.x_, imm.rmode_);
554 } 553 }
555 } // namespace internal 554 } // namespace internal
556 } // namespace v8 555 } // namespace v8
557 556
558 #endif // V8_X87_ASSEMBLER_X87_INL_H_ 557 #endif // V8_X87_ASSEMBLER_X87_INL_H_
OLDNEW
« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | test/cctest/heap/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698