Tools/Scripts/webkitpy/layout_tests/port/base.py - Issue 208743007: Add an actionable error message when image diff fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 208743007: Add an actionable error message when image diff fails. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Adjust test. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/Scripts/webkitpy/layout_tests/port/base.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/port/base.py b/Tools/Scripts/webkitpy/layout_tests/port/base.py

index d7cde1c62d51e39467a7a3a78892362d302144c5..66842c7a794a2ce30696d6b1c04a5d91b1b28200 100644

--- a/Tools/Scripts/webkitpy/layout_tests/port/base.py

+++ b/Tools/Scripts/webkitpy/layout_tests/port/base.py

@@ -506,7 +506,7 @@ class Port(object):

elif exit_code == 1:

result = self._filesystem.read_binary_file(native_diff_filename)

else:

- err_str = "image diff returned an exit code of %s" % exit_code

+ err_str = "Image diff returned an exit code of %s. See http://crbug.com/278596" % exit_code

except OSError, e:

err_str = 'error running image diff: %s' % str(e)

finally:

« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py » ('j') | no next file with comments »