Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py - Issue 208743007: Add an actionable error message when image diff fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

Issue 208743007: Add an actionable error message when image diff fails. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Adjust test. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py b/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

index 29b5313d0d6f1b7ef36e67e1ca0a89e3524e3a09..26efa4ba458a9bac8bc6826a5d0814441b3b25b3 100644

--- a/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

+++ b/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

@@ -228,7 +228,7 @@ class PortTestCase(unittest.TestCase):

def test_diff_image_crashed(self):

port = self.make_port()

port._executive = MockExecutive2(exit_code=2)

- self.assertEqual(port.diff_image("EXPECTED", "ACTUAL"), (None, 'image diff returned an exit code of 2'))

+ self.assertEqual(port.diff_image("EXPECTED", "ACTUAL"), (None, 'Image diff returned an exit code of 2. See http://crbug.com/278596'))

def test_check_wdiff(self):

port = self.make_port()

« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | no next file » | no next file with comments »