Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 208743007: Add an actionable error message when image diff fails. (Closed)

Created:
6 years, 9 months ago by chrishtr
Modified:
6 years, 9 months ago
Reviewers:
Dirk Pranke, ojan
CC:
blink-reviews
Visibility:
Public.

Description

Add an actionable error message when image diff fails. BUG=278596 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169995

Patch Set 1 #

Patch Set 2 : Adjust test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
chrishtr
6 years, 9 months ago (2014-03-25 23:32:01 UTC) #1
ojan
Did you run test-webkitpy? Do we not have any test coverage for this? lgtm if ...
6 years, 9 months ago (2014-03-25 23:42:28 UTC) #2
Dirk Pranke
I'd be kinda surprised if we have a test for this branch, but I could ...
6 years, 9 months ago (2014-03-26 00:03:40 UTC) #3
chrishtr
The test did indeed fail, just uploaded a patch that fixes it.
6 years, 9 months ago (2014-03-26 00:04:21 UTC) #4
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 9 months ago (2014-03-26 00:04:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/208743007/60001
6 years, 9 months ago (2014-03-26 00:04:38 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 01:12:39 UTC) #7
Message was sent while issue was closed.
Change committed as 169995

Powered by Google App Engine
This is Rietveld 408576698