content/browser/renderer_host/offscreen_canvas_surface_impl.h - Issue 2087383002: Fix destruction order between SurfaceManger and OffscreenCanvasSurfaceImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/offscreen_canvas_surface_impl.h

Issue 2087383002: Fix destruction order between SurfaceManger and OffscreenCanvasSurfaceImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix SurfaceIdAllocator's destructor Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/surfaces/surface_id_allocator.h ('K') | « content/browser/compositor/surface_utils.cc ('k') | content/browser/renderer_host/offscreen_canvas_surface_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/offscreen_canvas_surface_impl.h

diff --git a/content/browser/renderer_host/offscreen_canvas_surface_impl.h b/content/browser/renderer_host/offscreen_canvas_surface_impl.h

index c27abcaf74bb5e69027f58b43f73936ae5d5951b..fff1817ac113654bea8a7a8fbd87b4b7267a6884 100644

--- a/content/browser/renderer_host/offscreen_canvas_surface_impl.h

+++ b/content/browser/renderer_host/offscreen_canvas_surface_impl.h

@@ -41,6 +41,7 @@ class OffscreenCanvasSurfaceImpl : public blink::mojom::OffscreenCanvasSurface,

// Surface-related state

std::unique_ptr<cc::SurfaceIdAllocator> id_allocator_;

+ cc::SurfaceId surface_id_;

std::unique_ptr<cc::SurfaceFactory> surface_factory_;

mojo::StrongBinding<blink::mojom::OffscreenCanvasSurface> binding_;