Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: content/browser/renderer_host/offscreen_canvas_surface_impl.h

Issue 2087383002: Fix destruction order between SurfaceManger and OffscreenCanvasSurfaceImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix SurfaceIdAllocator's destructor Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_OFFSCREEN_CANVAS_SURFACE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_OFFSCREEN_CANVAS_SURFACE_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_OFFSCREEN_CANVAS_SURFACE_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_OFFSCREEN_CANVAS_SURFACE_IMPL_H_
7 7
8 #include "cc/surfaces/surface_factory.h" 8 #include "cc/surfaces/surface_factory.h"
9 #include "cc/surfaces/surface_factory_client.h" 9 #include "cc/surfaces/surface_factory_client.h"
10 #include "cc/surfaces/surface_id.h" 10 #include "cc/surfaces/surface_id.h"
(...skipping 23 matching lines...) Expand all
34 void WillDrawSurface(cc::SurfaceId id, const gfx::Rect& damage_rect) override; 34 void WillDrawSurface(cc::SurfaceId id, const gfx::Rect& damage_rect) override;
35 void SetBeginFrameSource(cc::BeginFrameSource* begin_frame_source) override; 35 void SetBeginFrameSource(cc::BeginFrameSource* begin_frame_source) override;
36 36
37 private: 37 private:
38 ~OffscreenCanvasSurfaceImpl() override; 38 ~OffscreenCanvasSurfaceImpl() override;
39 explicit OffscreenCanvasSurfaceImpl( 39 explicit OffscreenCanvasSurfaceImpl(
40 mojo::InterfaceRequest<blink::mojom::OffscreenCanvasSurface> request); 40 mojo::InterfaceRequest<blink::mojom::OffscreenCanvasSurface> request);
41 41
42 // Surface-related state 42 // Surface-related state
43 std::unique_ptr<cc::SurfaceIdAllocator> id_allocator_; 43 std::unique_ptr<cc::SurfaceIdAllocator> id_allocator_;
44 cc::SurfaceId surface_id_;
44 std::unique_ptr<cc::SurfaceFactory> surface_factory_; 45 std::unique_ptr<cc::SurfaceFactory> surface_factory_;
45 46
46 mojo::StrongBinding<blink::mojom::OffscreenCanvasSurface> binding_; 47 mojo::StrongBinding<blink::mojom::OffscreenCanvasSurface> binding_;
47 48
48 DISALLOW_COPY_AND_ASSIGN(OffscreenCanvasSurfaceImpl); 49 DISALLOW_COPY_AND_ASSIGN(OffscreenCanvasSurfaceImpl);
49 }; 50 };
50 51
51 } // namespace content 52 } // namespace content
52 53
53 #endif // CONTENT_BROWSER_RENDERER_HOST_OFFSCREEN_CANVAS_SURFACE_IMPL_H_ 54 #endif // CONTENT_BROWSER_RENDERER_HOST_OFFSCREEN_CANVAS_SURFACE_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698