Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: cc/surfaces/surface_factory.h

Issue 2087383002: Fix destruction order between SurfaceManger and OffscreenCanvasSurfaceImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix SurfaceIdAllocator's destructor Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/surfaces/surface_factory.cc » ('j') | cc/surfaces/surface_id_allocator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_factory.h
diff --git a/cc/surfaces/surface_factory.h b/cc/surfaces/surface_factory.h
index c869029cbaabe66cefb25c4934a5368bc9c7980c..99f0aeb54d1d4344775161248604dd4f1d684ea2 100644
--- a/cc/surfaces/surface_factory.h
+++ b/cc/surfaces/surface_factory.h
@@ -83,6 +83,10 @@ class CC_SURFACES_EXPORT SurfaceFactory
bool needs_sync_points() const { return needs_sync_points_; }
void set_needs_sync_points(bool needs) { needs_sync_points_ = needs; }
+ // SurfaceFactory's owner can call this when it finds out that SurfaceManager
+ // is no longer alive during destruction.
+ void didDestroySurfaceManager() { manager_ = nullptr; }
jbauman 2016/06/23 19:46:57 This should be called DidDestroySurfaceManager in
xlai (Olivia) 2016/06/23 20:09:28 Sorry I just landed the patch after being pushed t
+
private:
SurfaceManager* manager_;
SurfaceFactoryClient* client_;
« no previous file with comments | « no previous file | cc/surfaces/surface_factory.cc » ('j') | cc/surfaces/surface_id_allocator.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698